-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert into monorepo #609
Comments
I'll work on it. |
@snitin315 we still need this accepted by the TSC, so please hold off for now. |
@eslint/eslint-tsc still looking for feedback here. |
Sounds good to me 👍🏻 This will allow all three packages to share the same tooling so it should simplify maintenance. |
Sounds good to me too 👍 |
All three packages are already ESM. In that regard, a difference between these and eslint/rewrite packages is only that in these packages we're publishing ESM source code as-is (all files), whereas in eslint/rewrite packages we're publishing an ESM bundle. |
Ah, didn't realize everything was in ESM already. In rewrite, I'm bundling first to avoid @snitin315 this is ready for you. 🎉 |
@snitin315 are you still planning on working on this? |
@nzakas yes, I've made some progress locally will open a PR soon. |
We also need to rename the repo to something like does it make sense to also moving |
Eventually, yes, but that will be a lot of work. So we'll have to live with the confusion for a while. |
@nzakas I've added a new step: |
Renamed 👍 |
Is there anything remaining for this issue? |
I think no. but want @nzakas to verify. |
Looks like we got it all. Thanks @snitin315! 🙏 |
In our discussion of how to move forward with incorporating all of the JS-related packages into a single repo the vote was clear: people prefer a monorepo with individual packages.
Rather than creating a new repo and moving everything into that, I propose that we repurpose the Espree repo as a monorepo containing all of the JS-related packages. Because Espree is the one where we do the most work and have the most history, this seems like a good way to retain the package history while still moving us forward.
Here are the transition steps I have in mind.
Steps
packages/espree
release-please
configuration to be a monorepo setup (like `eslint/rewrite)eslint-scope
from its own repo intopackages/eslint-scope
and updaterelease-please
eslint-visitor-keys
from its own repo intopackages/eslint-visitor-keys
and updaterelease-please
Later Steps
After that, it would be nice to get the packages transitioned to ESM and type checking, but that can be done incrementally.
Note: I'm looking for volunteers to do this as I already have too much on my plate.
The text was updated successfully, but these errors were encountered: