Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert README template usage to flat #194

Merged
merged 4 commits into from
Oct 19, 2024

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Oct 19, 2024

Issue

Change

image

@MikeMcC399 MikeMcC399 marked this pull request as draft October 19, 2024 07:26
plugin/templates/_README.md Outdated Show resolved Hide resolved
plugin/templates/_README.md Outdated Show resolved Hide resolved
Co-authored-by: Milos Djermanovic <[email protected]>
@MikeMcC399 MikeMcC399 marked this pull request as draft October 19, 2024 10:32
@MikeMcC399 MikeMcC399 marked this pull request as ready for review October 19, 2024 10:46
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 779340a into eslint:main Oct 19, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
@MikeMcC399
Copy link
Contributor Author

@mdjermanovic

LGTM, thanks!

I'm happy I was able to successfully contribute with your assistance! Thank you too!

@MikeMcC399 MikeMcC399 deleted the fix/readme-template branch October 19, 2024 16:49
@nzakas
Copy link
Member

nzakas commented Nov 1, 2024

@MikeMcC399 we'd like to pay you for this contribution, but I couldn't find an email address for you. Please reach out to contact (at) eslint (dot) org. Thanks!

@MikeMcC399
Copy link
Contributor Author

@nzakas

we'd like to pay you for this contribution, but I couldn't find an email address for you. Please reach out to contact (at) eslint (dot) org. Thanks!

Thank you for your offer! Please accept my PR as a simple donation to your project. I wasn't expecting to be paid and I am happy to contribute to Open Source without being otherwise compensated.

@nzakas
Copy link
Member

nzakas commented Nov 1, 2024

@MikeMcC399 understood, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Generated plugin README has legacy config file reference
3 participants