Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add eslint-doc-generator to plugin template #140

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Conversation

bmish
Copy link
Member

@bmish bmish commented Nov 30, 2022

eslint-doc-generator is a CLI tool I built for automating the generation of the README rules list table and rule doc title/notices (e.g. auto-fixable, has suggestions, deprecated, etc) for ESLint plugins. It follows common documentation conventions from ESLint and top ESLint plugins and will help us standardize documentation across ESLint plugins (and generally improve the usability of custom rules through better documentation as well as streamline the process of adding new rules). It has 100% test coverage and is used in many of the top ESLint plugins already.

The primary change in this PR is to install the new dev-dependency and add the following scripts to the plugin template package.json:

  • npm run update:eslint-docs for the plugin author to update their documentation whenever adding a rule or changing rule metadata
  • npm run lint:eslint-docs which ensures the plugin's documentation is up-to-date (for running locally or during CI)

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice addition to me.

@nzakas nzakas merged commit 6878784 into main Dec 14, 2022
@nzakas nzakas deleted the eslint-doc-generator branch December 14, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants