feat: update templates for eslint v9

[aladdin-add]

1. use flat config
2. add .npmrc (package-lock=false), just same as eslint repo
3. update required node.js & eslint

fixes #172

[aladdin-add]

@mdjermanovic can you push a new release of eslint-config-eslint, to update eslint-plugin-unicorn for eslint v9 support?

[aladdin-add]

friendly ping @mdjermanovic

[mdjermanovic]

@mdjermanovic can you push a new release of eslint-config-eslint, to update eslint-plugin-unicorn for eslint v9 support?

Sorry, I missed this.

I believe eslint-config-eslint is fully ready for a new release in terms of its flat config part. But it still exports an eslintrc config, which we haven't been updating for a while and is probably out-of-sync with the flat config. Since it's a public package, my thinking was to wait for eslint/eslint#18011 (which drops the eslintrc export) before releasing new eslint-config-eslint, but I'm open to other ideas.

[aladdin-add]

The exported eslinrc was exclusively utilized within the eslint repo. Additionally, the progress of eslint/eslint#18011 was blocked by vscode-eslint😅. I am in favor of pushing a release to unblock eslint repos upgrading to eslint v9.

[mdjermanovic]

The exported eslinrc was exclusively utilized within the eslint repo

That's true for our repos, but it's still a public package used by others as well, so the expectation would be that the flat config and eslintrc exports are equivalent, which most likely isn't the case anymore. I left an idea in eslint/eslint#18011 (comment).

[aladdin-add]

Actually eslintrc was not published to npm, so there should be no external users.

[mdjermanovic]

Actually eslintrc was not published to npm, so there should be no external users.

Yes, but there might be when we release it. And I think it's anyway best to release eslint-config-eslint v10 without eslintrc.

[MikeMcC399]

Here are a couple of suggestions:

• Since Node.js 21 reaches end-of-life on June 1, 2024 I suggest to replace it with Node.js 22, which was released already on April 24, 2024. (Also in .github/workflows/ci.yml)
• Replace the unmaintained npm-run-all (last released 5 years ago) with the compatible, maintained fork npm-run-all2

[aladdin-add]

Since Node.js 21 reaches end-of-life on June 1, 2024 I suggest to replace it with Node.js 22, which was released already on April 24, 2024. (Also in .github/workflows/ci.yml)

yes, but node v21 is still supported - dropping it is a breaking change. I just added v22.

[MikeMcC399]

@aladdin-add

You are right about the breaking change. Sorry I didn't notice that!

[MikeMcC399]

npm reports peer dependency issues due to eslint-doc-generator after using yo eslint:plugin.

generator-eslint/plugin/templates/_package.json

Line 26 in e0af2aa

"eslint-doc-generator": "^1.0.0",

• This pulls in "eslint-doc-generator": "^1.0.0" which has an indirect issue with peer dependencies on ESLint v9 due to missing ESLint v9 Support typescript-eslint/typescript-eslint#8211

• I have logged that as a separate issue on Peer dependency warnings on ESLint v9 bmish/eslint-doc-generator#525

[mdjermanovic]

I ran yo eslint:plugin to create a plugin and it was successful.

But, running npm run lint:js in the plugin reports:

C:\projects\tmp\tmp\eslint.config.mjs
  1:1  error  Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

✖ 1 problem (1 error, 0 warnings)

[aladdin-add]

fixed in ed00e49

[mdjermanovic]

LGTM, thanks!