-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Add /universal entrypoint (fixes #50) #51
Conversation
Updated eslint/eslint#14865 to use this branch, but the Browser Test still doesn't work.
I believe this is the cause: Lines 12 to 15 in 3983fde
( We might need to copy the content of |
}, | ||
"files": [ | ||
"lib", | ||
"conf", | ||
"LICENSE", | ||
"dist/eslintrc.cjs" | ||
"dist" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"dist" | |
"dist/eslintrc.cjs", | |
"dist/eslintrc-universal.cjs" |
if we don't want to publish .map
files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't think of a reason not to publish map files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, we are not publishing map files in other dual packages e.g., eslint/eslint-visitor-keys#24 (comment)
Oops, good call. Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, all checks have passed on eslint/eslint#14865.
Adds a new
/universal
entrypoint that exports only members that are browser-safe. Once this is merged, we should change this line in linter.js from:to