-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add guidelines for patch release communication (fixes #7277) #8823
Conversation
This updates the release documentation to describe how to use release issues to communicate releases to the team.
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, just a few minor suggestions (no show-stoppers).
docs/maintainer-guide/releases.md
Outdated
1. Make release announcement on Twitter. | ||
1. Remind the team not to merge anything other than documentation changes and bug fixes. | ||
1. Update the release blog post with a "Highlights" section, including new rules and anything else that's important. | ||
1. Make a release announcement in the chatroom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're doing a clarity pass, should we say "public chatroom" to be very clear here? Probably not necessary but something to consider.
docs/maintainer-guide/releases.md
Outdated
After the patch release has been published (or no patch release is necessary), inform the team that they can start merging in changes again. | ||
In rare cases, a second patch release might be necessary if the release is known to have a severe regression that hasn't been fixed by Monday. If this occurs, the release team should announce the situation on the release issue, and leave the issue open until all patch releases are complete. However, it's usually better to fix bugs for the next release cycle rather than doing a second patch release. | ||
|
||
After the patch release has been published (or no patch release is necessary), close the release issue and inform the team that they can start merging in changes again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/merging in changes/merging in semver-minor changes?
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ LGTM, thanks!
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
This updates the release documentation to describe how to use release issues to communicate releases to the team.
Is there anything you'd like reviewers to focus on?
Is there anything important I missed?