Update: for-direction detection false positives/negatives

[BridgeAR]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

I updated the for-direction rule to prevent false positives and false negatives.

Is there anything you'd like reviewers to focus on?

No

[platinumazure]

Thanks for contributing! Left one inline note.

In addition: Could you please add tests (if not already present) for cases where the for increment direction "could be wrong" but the step size is a variable?

For example:

for(var i = 0; i < MAX; i -= STEP_SIZE);

To me, those examples should be valid because we don't know if STEP_SIZE is positive or negative.

Also, since this change can introduce more warnings, the commit summary tag should say "Update". Would you mind making that change as well? (Simplest way to do that is to push new commits without squashing, then edit the PR title.)

[platinumazure]

Looks like this should say i > MIN.

[BridgeAR]

It was meant as test which you requested and I was to lazy to change the variable names, so it seemed confusing afterwards. I fixed that now and added another one on top.

[not-an-aardvark]

@platinumazure Friendly ping, have your suggestions been addressed?

[platinumazure]

LGTM, thanks! Sorry for not following up sooner.