feat: Add isGlobalReturn method on scopeManager. (#96)

Renames the private __isNodejsScope to isGlobalReturn to formally make it part of the interface and available in ESLint. Refs eslint/eslint#16999
eslint · Apr 12, 2023 · 70c8db1 · 70c8db1
1 parent 3dbad80
commit 70c8db1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/lib/referencer.js b/lib/referencer.js
@@ -409,7 +409,7 @@ class Referencer extends esrecurse.Visitor {
     Program(node) {
         this.scopeManager.__nestGlobalScope(node);
 
-        if (this.scopeManager.__isNodejsScope()) {
+        if (this.scopeManager.isGlobalReturn()) {
 
             // Force strictness of GlobalScope to false when using node.js scope.
             this.currentScope().isStrict = false;

diff --git a/lib/scope-manager.js b/lib/scope-manager.js
@@ -65,7 +65,7 @@ class ScopeManager {
         return this.__options.ignoreEval;
     }
 
-    __isNodejsScope() {
+    isGlobalReturn() {
         return this.__options.nodejsScope || this.__options.sourceType === "commonjs";
     }
 

diff --git a/tests/nodejs-scope.js b/tests/nodejs-scope.js
@@ -38,6 +38,7 @@ describe("nodejsScope option", () => {
         const scopeManager = analyze(ast, { ecmaVersion: 6, nodejsScope: true });
 
         expect(scopeManager.scopes).to.have.length(2);
+        expect(scopeManager.isGlobalReturn()).to.be.true;
 
         let scope = scopeManager.scopes[0];
 
@@ -64,6 +65,7 @@ describe("nodejsScope option", () => {
         const scopeManager = analyze(ast, { ecmaVersion: 6, sourceType: "commonjs" });
 
         expect(scopeManager.scopes).to.have.length(2);
+        expect(scopeManager.isGlobalReturn()).to.be.true;
 
         let scope = scopeManager.scopes[0];
 
@@ -87,6 +89,7 @@ describe("nodejsScope option", () => {
         const scopeManager = analyze(ast, { ecmaVersion: 6, nodejsScope: true, sourceType: "module" });
 
         expect(scopeManager.scopes).to.have.length(3);
+        expect(scopeManager.isGlobalReturn()).to.be.true;
 
         let scope = scopeManager.scopes[0];