feat: always treat PR title as the default commit message #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
commented
Sep 12, 2023
| expect(nockScope.isDone()).toBeTruthy(); | ||
| expect(nockScope2.isDone()).toBeTruthy(); | ||
| expect(labelsScope.isDone()).toBeFalsy(); | ||
| }); | ||
|
|
||
| test("Posts success status if the commit message is longer than 72 chars after the newline", async () => { |
There was a problem hiding this comment.
I think this test wouldn't make sense with PR titles, so I've just deleted it.
snitin315
approved these changes
Sep 12, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs eslint/eslint#17555
Updates the logic related to commit messages to always treat the PR title as the default commit message. The change is made in the following plugins:
commit-message: it will always validate the PR title and add labels based on the tag from the PR title.release-monitor: it will set the pending status based on the tag from the PR title.Note:
release-monitorstill expects the old tags, so currently it basically disallows merging any PRs. I didn't fix that now. I think we should revisit our rules for merging PRs after releases, so I'll open an issue to discuss that and fix this plugin in a separate PR.