test: replace esmock with sinon #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| error: logErrorStub | ||
| } | ||
| }); | ||
| sinon.replaceGetter(log, "error", () => logErrorStub); |
There was a problem hiding this comment.
This replaces a property on the module namespace object?
There was a problem hiding this comment.
Yes, do you know of a better way to do that?
There was a problem hiding this comment.
Nope, I just don't understand how it can work, shouldn't module namespace objects be frozen?
There was a problem hiding this comment.
I think that Vitest does some kind of bundling or transpiling, which is also why the unit tests cannot be debugged.
There was a problem hiding this comment.
Yeah, it seems that when running through Vitest this isn't a real namespace object.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests in Node.js 22.2.0 by using sinon to mock dependencies instead of esmock.
Fixes #116