-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch rule files automatically #180
Conversation
@Dimava and @Julien-R44 please review this PR and give me some feedback |
LGTM ! Much simpler than my over-engineered system with ASTs ahah 🤪 Do we agree that we can now close #142 ? |
@Shinigami92 LGTM What happens if diff is not appliable? BTW, would adding EventEmitter be a good idea for streamlining logging, counting and #137 ? |
@Shinigami92 please add fixes for #181 |
Will do in separate PR 👍 |
I have not checked that, but I assume it would fail or something like that
Could you explain a bit more? Maybe outsource this discussion into a new separate issue/discussion |
Running
pnpm run generate:rules
results in some files that are invalidWe can run
git diff -R src/rules/<plugin>/<rule>.d.ts > scripts/generate-rule-files/diffs/rules/<plugin>/<rule>.d.ts.diff
to generate a diff file that reverts what is invalid