Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functional/functional-parameters in recommended/lite configs not working anymore #885

Closed
essenmitsosse opened this issue Oct 8, 2024 · 0 comments
Labels
Type: Bug Inconsistencies or issues which will cause a problem for users or implementors.

Comments

@essenmitsosse
Copy link

Bug Report

After the change in #811 that changed the options for functional/functional-parameters in recommended and lite configs the rule is not working anymore. It is still working though when defined manually via functional/functional-parameters: "error".

Expected behavior

Those functions should throw an error for functional/functional-parameters.

function add() {
    return arguments.reduce((sum, number) => sum + number, 0);
}

const foo = () => 3;

Actual behavior

They don't throw an error if the rule is used via the recommended or lite configs.

Steps to reproduce

Use the recommended or lite config and write any function without arguments.

Proposed changes

Either I am not understanding something about the changes in #811 (and maybe also #803) — in which case the documentation should be updated, or the new configuration for the rule in the recommended and lite configs is not working anymore as intended.

@essenmitsosse essenmitsosse added Status: Triage This issue needs to be triaged. Type: Bug Inconsistencies or issues which will cause a problem for users or implementors. labels Oct 8, 2024
@RebeccaStevens RebeccaStevens removed the Status: Triage This issue needs to be triaged. label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

2 participants