Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(no-callback-in-promise): false triggering of callback #574

Merged
merged 3 commits into from
Nov 26, 2024
Merged

fix(no-callback-in-promise): false triggering of callback #574

merged 3 commits into from
Nov 26, 2024
+32 −13

Conversation

brettz9
Copy link
Member

@brettz9 brettz9 commented Nov 26, 2024

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Other, please explain:

What changes did you make? (Give an overview)

Fixes regression with false triggering by callback

Fixes #572

scagood
scagood approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me 👍

rules/no-callback-in-promise.js Outdated Show resolved Hide resolved
ota-meshi
ota-meshi approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 8324564 into eslint-community:main Nov 26, 2024
9 checks passed
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Merged
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Nov 27, 2024
@renovate
fix(deps): update dependency eslint-plugin-promise to v7.2.1
6761412 
##### [v7.2.1](https://github.com/eslint-community/eslint-plugin-promise/blob/HEAD/CHANGELOG.md#721-2024-11-26)

##### 🩹 Fixes

-   **`no-callback-in-promise`:** false triggering of callback ([#574](eslint-community/eslint-plugin-promise#574)) ([8324564](eslint-community/eslint-plugin-promise@8324564))

##### 🧹 Chores

-   **deps-dev:** update husky to v9.1.7 ([#573](eslint-community/eslint-plugin-promise#573)) ([24fd90a](eslint-community/eslint-plugin-promise@24fd90a))
-   **deps:** bump cross-spawn from 7.0.3 to 7.0.6 ([#568](eslint-community/eslint-plugin-promise#568)) ([f33f82e](eslint-community/eslint-plugin-promise@f33f82e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

@scagood scagood scagood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive of no-callback-in-promise in 7.2.0
3 participants
@brettz9 @scagood @ota-meshi