Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add pr title format validation #509

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

voxpelli
Copy link
Member

What is the purpose of this pull request?

To assist #508 / #506 by ensuring that PR-title's are always valid conventional commit format before merging

What changes did you make? (Give an overview)

Added a pinned mtfoley/pr-compliance-action similar to what I use at eg. neostandard: https://github.com/neostandard/neostandard/blob/main/.github/workflows/compliance.yml

@voxpelli voxpelli requested a review from a team July 24, 2024 11:07
@scagood

This comment was marked as resolved.

@voxpelli
Copy link
Member Author

@scagood I believe that's only enforced in enterprise organizations

Copy link
Contributor

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@voxpelli
Copy link
Member Author

I added it to the ruleset now, but yeah, not enforced :)

Skärmavbild 2024-07-24 kl  16 24 08

@voxpelli voxpelli merged commit 1e13293 into main Jul 24, 2024
12 checks passed
@voxpelli voxpelli deleted the voxpelli/validate-pr-title branch July 24, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants