-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add strict
option to disallow then
or catch
following await
or yield
#494
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 24 -1
Lines 649 661 +12
Branches 250 247 -3
=========================================
+ Hits 649 661 +12 ☔ View full report in Codecov by Sentry. |
…ait` or `yield`; fixes eslint-community#294
30e47d8
to
fe99945
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🎉 This PR is included in version 6.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
##### [v6.6.0](https://github.com/eslint-community/eslint-plugin-promise/releases/tag/v6.6.0) ##### Bug Fixes - **`always-return`:** treat process.exit() or process.abort() as an acceptable "return" ([#493](eslint-community/eslint-plugin-promise#493)) ([f368c5a](eslint-community/eslint-plugin-promise@f368c5a)) ##### Features - add `strict` option to disallow `then` or `catch` following `await` or `yield` ([#494](eslint-community/eslint-plugin-promise#494)) ([fa482cc](eslint-community/eslint-plugin-promise@fa482cc)) ##### [v6.5.1](eslint-community/eslint-plugin-promise@v6.5.0...c011a1a) ##### [v6.5.0](eslint-community/eslint-plugin-promise@v6.4.0...46667d3) ##### [v6.4.0](eslint-community/eslint-plugin-promise@4dfc8a7...ecbce9f) ##### [v6.3.0](eslint-community/eslint-plugin-promise@v6.2.0...4dfc8a7) ##### [v6.2.0](eslint-community/eslint-plugin-promise@v6.1.1...5e4546d)
##### [v6.6.0](https://github.com/eslint-community/eslint-plugin-promise/releases/tag/v6.6.0) ##### Bug Fixes - **`always-return`:** treat process.exit() or process.abort() as an acceptable "return" ([#493](eslint-community/eslint-plugin-promise#493)) ([f368c5a](eslint-community/eslint-plugin-promise@f368c5a)) ##### Features - add `strict` option to disallow `then` or `catch` following `await` or `yield` ([#494](eslint-community/eslint-plugin-promise#494)) ([fa482cc](eslint-community/eslint-plugin-promise@fa482cc)) ##### [v6.5.1](eslint-community/eslint-plugin-promise@v6.5.0...c011a1a) ##### [v6.5.0](eslint-community/eslint-plugin-promise@v6.4.0...46667d3) ##### [v6.4.0](eslint-community/eslint-plugin-promise@4dfc8a7...ecbce9f) ##### [v6.3.0](eslint-community/eslint-plugin-promise@v6.2.0...4dfc8a7) ##### [v6.2.0](eslint-community/eslint-plugin-promise@v6.1.1...5e4546d)
##### [v6.6.0](https://github.com/eslint-community/eslint-plugin-promise/releases/tag/v6.6.0) ##### Bug Fixes - **`always-return`:** treat process.exit() or process.abort() as an acceptable "return" ([#493](eslint-community/eslint-plugin-promise#493)) ([f368c5a](eslint-community/eslint-plugin-promise@f368c5a)) ##### Features - add `strict` option to disallow `then` or `catch` following `await` or `yield` ([#494](eslint-community/eslint-plugin-promise#494)) ([fa482cc](eslint-community/eslint-plugin-promise@fa482cc)) ##### [v6.5.1](eslint-community/eslint-plugin-promise@v6.5.0...c011a1a) ##### [v6.5.0](eslint-community/eslint-plugin-promise@v6.4.0...46667d3) ##### [v6.4.0](eslint-community/eslint-plugin-promise@4dfc8a7...ecbce9f) ##### [v6.3.0](eslint-community/eslint-plugin-promise@v6.2.0...4dfc8a7) ##### [v6.2.0](eslint-community/eslint-plugin-promise@v6.1.1...5e4546d)
##### [v6.6.0](https://github.com/eslint-community/eslint-plugin-promise/releases/tag/v6.6.0) ##### Bug Fixes - **`always-return`:** treat process.exit() or process.abort() as an acceptable "return" ([#493](eslint-community/eslint-plugin-promise#493)) ([f368c5a](eslint-community/eslint-plugin-promise@f368c5a)) ##### Features - add `strict` option to disallow `then` or `catch` following `await` or `yield` ([#494](eslint-community/eslint-plugin-promise#494)) ([fa482cc](eslint-community/eslint-plugin-promise@fa482cc)) ##### [v6.5.1](eslint-community/eslint-plugin-promise@v6.5.0...c011a1a) ##### [v6.5.0](eslint-community/eslint-plugin-promise@v6.4.0...46667d3) ##### [v6.4.0](eslint-community/eslint-plugin-promise@4dfc8a7...ecbce9f) ##### [v6.3.0](eslint-community/eslint-plugin-promise@v6.2.0...4dfc8a7) ##### [v6.2.0](eslint-community/eslint-plugin-promise@v6.1.1...5e4546d)
##### [v6.6.0](https://github.com/eslint-community/eslint-plugin-promise/releases/tag/v6.6.0) ##### Bug Fixes - **`always-return`:** treat process.exit() or process.abort() as an acceptable "return" ([#493](eslint-community/eslint-plugin-promise#493)) ([f368c5a](eslint-community/eslint-plugin-promise@f368c5a)) ##### Features - add `strict` option to disallow `then` or `catch` following `await` or `yield` ([#494](eslint-community/eslint-plugin-promise#494)) ([fa482cc](eslint-community/eslint-plugin-promise@fa482cc)) ##### [v6.5.1](eslint-community/eslint-plugin-promise@v6.5.0...c011a1a) ##### [v6.5.0](eslint-community/eslint-plugin-promise@v6.4.0...46667d3) ##### [v6.4.0](eslint-community/eslint-plugin-promise@4dfc8a7...ecbce9f) ##### [v6.3.0](eslint-community/eslint-plugin-promise@v6.2.0...4dfc8a7) ##### [v6.2.0](eslint-community/eslint-plugin-promise@v6.1.1...5e4546d)
##### [v6.6.0](https://github.com/eslint-community/eslint-plugin-promise/releases/tag/v6.6.0) ##### Bug Fixes - **`always-return`:** treat process.exit() or process.abort() as an acceptable "return" ([#493](eslint-community/eslint-plugin-promise#493)) ([f368c5a](eslint-community/eslint-plugin-promise@f368c5a)) ##### Features - add `strict` option to disallow `then` or `catch` following `await` or `yield` ([#494](eslint-community/eslint-plugin-promise#494)) ([fa482cc](eslint-community/eslint-plugin-promise@fa482cc)) ##### [v6.5.1](eslint-community/eslint-plugin-promise@v6.5.0...c011a1a) ##### [v6.5.0](eslint-community/eslint-plugin-promise@v6.4.0...46667d3) ##### [v6.4.0](eslint-community/eslint-plugin-promise@4dfc8a7...ecbce9f) ##### [v6.3.0](eslint-community/eslint-plugin-promise@v6.2.0...4dfc8a7) ##### [v6.2.0](eslint-community/eslint-plugin-promise@v6.1.1...5e4546d)
##### [v6.6.0](https://github.com/eslint-community/eslint-plugin-promise/releases/tag/v6.6.0) ##### Bug Fixes - **`always-return`:** treat process.exit() or process.abort() as an acceptable "return" ([#493](eslint-community/eslint-plugin-promise#493)) ([f368c5a](eslint-community/eslint-plugin-promise@f368c5a)) ##### Features - add `strict` option to disallow `then` or `catch` following `await` or `yield` ([#494](eslint-community/eslint-plugin-promise#494)) ([fa482cc](eslint-community/eslint-plugin-promise@fa482cc)) ##### [v6.5.1](eslint-community/eslint-plugin-promise@v6.5.0...c011a1a) ##### [v6.5.0](eslint-community/eslint-plugin-promise@v6.4.0...46667d3) ##### [v6.4.0](eslint-community/eslint-plugin-promise@4dfc8a7...ecbce9f) ##### [v6.3.0](eslint-community/eslint-plugin-promise@v6.2.0...4dfc8a7) ##### [v6.2.0](eslint-community/eslint-plugin-promise@v6.1.1...5e4546d)
##### [v6.6.0](https://github.com/eslint-community/eslint-plugin-promise/releases/tag/v6.6.0) ##### Bug Fixes - **`always-return`:** treat process.exit() or process.abort() as an acceptable "return" ([#493](eslint-community/eslint-plugin-promise#493)) ([f368c5a](eslint-community/eslint-plugin-promise@f368c5a)) ##### Features - add `strict` option to disallow `then` or `catch` following `await` or `yield` ([#494](eslint-community/eslint-plugin-promise#494)) ([fa482cc](eslint-community/eslint-plugin-promise@fa482cc)) ##### [v6.5.1](eslint-community/eslint-plugin-promise@v6.5.0...c011a1a) ##### [v6.5.0](eslint-community/eslint-plugin-promise@v6.4.0...46667d3) ##### [v6.4.0](eslint-community/eslint-plugin-promise@4dfc8a7...ecbce9f) ##### [v6.3.0](eslint-community/eslint-plugin-promise@v6.2.0...4dfc8a7) ##### [v6.2.0](eslint-community/eslint-plugin-promise@v6.1.1...5e4546d)
feat: add
strict
option to disallowthen
orcatch
followingawait
oryield
Fixes #294
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Added a
strict
option which disallowsthen
orcatch
followingawait
oryield
.