chore: bump dev dependencies #483

scagood · 2024-07-16T09:24:09Z

Bumped all packages (except eslint) to the latest version.
Replaced eslint-plugin-node with eslint-plugin-n

scagood · 2024-07-17T09:09:13Z

🤔 So now comes the time I need to know if we:

Keep supporting node versions for eslint v8 (Roll all versions back to points where 12.22)
Drop supporting node versions for eslint v8 (Bump package engines to match eslint v9 ^18.18.0 || ^20.9.0 || >=21.1.0) (eg in fc861bf)

brettz9 · 2024-07-17T09:54:48Z

Can't we keep supporting ESLint v8 while bumping the Node requirements? We don't have to support every possible install which can handle ESLint 8.

scagood · 2024-07-17T10:23:07Z

Can't we keep supporting ESLint v8 while bumping the Node requirements? We don't have to support every possible install which can handle ESLint 8.

Ah, yes, sorry I miss wrote, you're 100% right, it'd be just dropping node versions for the eslint version! 😅

You can see that I left eslint v8 support in the mentioned commit 😶‍🌫️ fc861bf

edited original comment to cleanup the misunderstanding

brettz9 · 2024-07-17T10:27:40Z

I think the bumped Node may also address your CI issues.

scagood · 2024-07-17T10:33:36Z

I think the bumped Node may also address your CI issues.

You'd be correct there :)

Will rebase if #484 is accepted

package.json

codecov · 2024-07-24T08:28:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bbcfcbf) to head (5cc5a43).
Report is 28 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #483   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        24    -1     
  Lines          649       661   +12     
  Branches       250       247    -3     
=========================================
+ Hits           649       661   +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

scagood

Its about now, I realised I missed actually posting these comments 👀

scagood · 2024-07-24T08:45:04Z

README.md

+🔧 Automatically fixable by the
+[`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).


There was a little fight between eslint-doc-generator and prettier here 🤔
Prettier seems to win...

Ugh, I would like to remove prettier :/

scagood · 2024-07-24T08:47:52Z

package.json

@@ -26,7 +26,7 @@
    "lint": "npm-run-all \"lint:*\"",
    "lint:eslint-docs": "npm run update:eslint-docs && git diff --exit-code",
    "lint:js": "eslint --report-unused-disable-directives .",
-    "prepare": "husky install",
+    "prepare": "husky",


Im not sure what husky really brings to the table.

The entire husky package looks to be replaceable with one command:

git config core.hooksPath .husky

It at least brings convention, I like it sometimes

🤖 I have created a release *beep* *boop* --- ## [7.1.0](v7.0.0...v7.1.0) (2024-08-06) ### 🌟 Features * **`catch-or-return`, `prefer-await-to-then`:** do not report Cypress commands ([#495](#495)) ([943f162](943f162)) * **`prefer-await-to-then`:** ignore constructor scope unless with `strict` option ([#496](#496)) ([7bffb7a](7bffb7a)) * new rule `spec-only` to check for non-spec Promise methods ([#502](#502)) ([d6e9de1](d6e9de1)) ### 📚 Documentation * fixes the CI readme badge ([#511](#511)) ([030a3be](030a3be)) * supply missing docs ([#503](#503)) ([602d825](602d825)) ### 🧹 Chores * bump dev dependencies ([#483](#483)) ([197ae4e](197ae4e)) * **deps-dev:** bump husky from 9.1.1 to 9.1.2 ([#516](#516)) ([ab8e7a0](ab8e7a0)) * file extension missing ([#519](#519)) ([94c9834](94c9834)) * fix format.yml ([#507](#507)) ([948c097](948c097)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

This comment was marked as resolved.

Sign in to view

scagood force-pushed the packages branch from 80694db to 5a47dc0 Compare July 17, 2024 08:54

brettz9 added the chore label Jul 19, 2024

voxpelli approved these changes Jul 19, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

scagood force-pushed the packages branch from 5a47dc0 to fba6fa5 Compare July 24, 2024 08:26

scagood force-pushed the packages branch 3 times, most recently from d108a58 to a5dfa2b Compare July 24, 2024 08:38

scagood added 3 commits July 24, 2024 09:42

feat: Bump all packages to latest versions

a734346

ci: Update pre-commit hook

43dab70

chore: npm run lint

5cc5a43

scagood force-pushed the packages branch from a5dfa2b to 5cc5a43 Compare July 24, 2024 08:42

scagood marked this pull request as ready for review July 24, 2024 09:11

voxpelli approved these changes Jul 24, 2024

View reviewed changes

voxpelli changed the title ~~feat: Bump all packages to latest versions~~ chore: bump dev dependencies Jul 24, 2024

voxpelli merged commit 197ae4e into eslint-community:main Jul 24, 2024
12 checks passed

scagood deleted the packages branch July 24, 2024 10:08

scagood commented Jul 24, 2024

View reviewed changes

github-actions bot mentioned this pull request Jul 24, 2024

chore(main): release 7.1.0 #510

Merged

lholmquist mentioned this pull request Aug 28, 2024

[Snyk] Upgrade eslint-plugin-promise from 6.5.0 to 7.1.0 nodeshift/kube-service-bindings#221

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump dev dependencies #483

chore: bump dev dependencies #483

scagood commented Jul 16, 2024 •

edited

Loading

This comment was marked as resolved.

scagood commented Jul 17, 2024 •

edited

Loading

brettz9 commented Jul 17, 2024

scagood commented Jul 17, 2024 •

edited

Loading

brettz9 commented Jul 17, 2024

scagood commented Jul 17, 2024 •

edited

Loading

codecov bot commented Jul 24, 2024 •

edited

Loading

scagood left a comment

scagood Jul 24, 2024 •

edited

Loading

voxpelli Jul 24, 2024

scagood Jul 24, 2024

voxpelli Jul 24, 2024

		🔧 Automatically fixable by the
		[`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).

chore: bump dev dependencies #483

chore: bump dev dependencies #483

Conversation

scagood commented Jul 16, 2024 • edited Loading

This comment was marked as resolved.

scagood commented Jul 17, 2024 • edited Loading

brettz9 commented Jul 17, 2024

scagood commented Jul 17, 2024 • edited Loading

brettz9 commented Jul 17, 2024

scagood commented Jul 17, 2024 • edited Loading

codecov bot commented Jul 24, 2024 • edited Loading

Codecov Report

scagood left a comment

Choose a reason for hiding this comment

scagood Jul 24, 2024 • edited Loading

Choose a reason for hiding this comment

voxpelli Jul 24, 2024

Choose a reason for hiding this comment

scagood Jul 24, 2024

Choose a reason for hiding this comment

voxpelli Jul 24, 2024

Choose a reason for hiding this comment

scagood commented Jul 16, 2024 •

edited

Loading

scagood commented Jul 17, 2024 •

edited

Loading

scagood commented Jul 17, 2024 •

edited

Loading

scagood commented Jul 17, 2024 •

edited

Loading

codecov bot commented Jul 24, 2024 •

edited

Loading

scagood Jul 24, 2024 •

edited

Loading