-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Improve typescript types and strictness #367
Conversation
I do still need to work on the type tests, I may see if I can steal from #366 😅 |
This comment was marked as resolved.
This comment was marked as resolved.
cbc7120
to
98d5fb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. confirmed the generated typings is right. 👍
technically it fixes #320. Did you not close it for the subsequent task of adding type tests? 😄 |
@voxpelli, @MichaelDeBoey, PTAL. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me think that we should port the codebase to pure TS at one point in the (near) future 🤔
CC/ @eslint-community/eslint-plugin-node
I am currently in the jsdoc > typescript camp for a few reasons:
Its not that I am not against using typescript, I just find that I prefer jsdoc 🤔 |
This adds a much stricter tsconfig.
It looks like this does now correctly export the types too.