-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(no-unsupported-features): Update to v21.6.1 of node #180
Conversation
@aladdin-add Do you think that splitting the node modules up like this makes sense? In the future I would also like to merge the |
98e561f
to
33f5b4b
Compare
👍 seems a good direction! just a few thoughts:
|
548d2b0
to
b0ffbac
Compare
It would also be lovely to have a mechanism to detect instances of constructed properties 😢 Maybe its possible using the ts parser 🤔 const buffer = Buffer.from('asdasd');
// It'd be nice to mark this as deprecated somehow
buffer.parent I am not sure if a json file is better than a JS file here, because the file would need to be pre-processed into JS anyway. |
9afbc22
to
4bb1361
Compare
4bb1361
to
8bd0964
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
const { READ } = require("@eslint-community/eslint-utils") | ||
|
||
/** @type {import('../types.js').SupportVersionTree} */ | ||
const static = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static
is a reserved keyword and will throw in strict mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱 Good catch
This is a work in progress... I spent some time going through the node docs for this. Unfortunatly this is very much not automatable currently 😢
Hopefully its a good base to start from though as we keep the list updated from here.
I still need to:
lib/rules/no-unsupported-features/node-builtins.js
(There are some noticable differences)Extract the globals from the modules to bind them to the trackMap.Addconsole
as globalAddprocess
as global