Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen the dependency versions #106

Closed
wants to merge 1 commit into from
Closed

Loosen the dependency versions #106

wants to merge 1 commit into from

Conversation

boris-petrov
Copy link

So that people don't get multiple versions of these packages in their lock files if they use a newer version (like @typescript-eslint 5.60.0).

cc @MichaelDeBoey

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (1474691) 97.22% compared to head (7319554) 97.22%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files          40       40           
  Lines         397      397           
=======================================
  Hits          386      386           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MichaelDeBoey
Copy link
Member

This would break CI in the future (see #29)

@MichaelDeBoey
Copy link
Member

@boris-petrov I created #107 to update all dependencies to latest minor version

@boris-petrov
Copy link
Author

@MichaelDeBoey note that this is already outdated as there is version 5.61.0 now and you have to create a new commit to update to it. I'm not sure if that's the best way to do things. CI is there for exactly that - to catch breakages early and you to be able to fix them. 😄 But it's your decision in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants