feat: update eslint-plugin-node + update configs (#24)

* feat: update `eslint-plugin-node` + update configs BREAKING CHANGE: `+node`, `es5`, `es2015`, `es2016`, `es2017`, `es2018`, `es2019`, `es2020`, `es2021` & `es2022` configs now have extra rules from `eslint-plugin-node` * chore: fix ESLint errors
eslint-community · Oct 17, 2022 · bbaf218 · bbaf218
1 parent b08d8b6
commit bbaf218
Show file tree

Hide file tree

Showing 19 changed files with 44 additions and 28 deletions.
diff --git a/.eslintrc.yml b/.eslintrc.yml
@@ -2,3 +2,18 @@ root: true
 extends:
     - plugin:@eslint-community/mysticatea/es2015
     - plugin:@eslint-community/mysticatea/+eslint-plugin
+
+overrides:
+    - files: ["lib/utils.js", "scripts/*.js"]
+      rules:
+          "@eslint-community/mysticatea/node/no-sync": off
+
+    - files:
+          [
+              "lib/configs.js",
+              "lib/foreign-rules/ts.js",
+              "lib/processors.js",
+              "lib/rules.js",
+          ]
+      rules:
+          "@eslint-community/mysticatea/node/global-require": off
diff --git a/lib/configs/+node.js b/lib/configs/+node.js
@@ -46,6 +46,7 @@ module.exports = {
         require: "readonly",
     },
     rules: {
+        "@eslint-community/mysticatea/node/callback-return": "error",
         "@eslint-community/mysticatea/node/exports-style": [
             "error",
             "module.exports",
@@ -55,13 +56,23 @@ module.exports = {
             "always",
             { ".js": "never", ".ts": "never", ".tsx": "never" },
         ],
+        "@eslint-community/mysticatea/node/global-require": "error",
+        "@eslint-community/mysticatea/node/handle-callback-err": "error",
         "@eslint-community/mysticatea/node/no-callback-literal": "off",
         "@eslint-community/mysticatea/node/no-deprecated-api": "error",
         "@eslint-community/mysticatea/node/no-exports-assign": "error",
         "@eslint-community/mysticatea/node/no-extraneous-import": "error",
         "@eslint-community/mysticatea/node/no-extraneous-require": "error",
         "@eslint-community/mysticatea/node/no-missing-import": "error",
         "@eslint-community/mysticatea/node/no-missing-require": "error",
+        "@eslint-community/mysticatea/node/no-mixed-requires": "error",
+        "@eslint-community/mysticatea/node/no-new-require": "error",
+        "@eslint-community/mysticatea/node/no-path-concat": "error",
+        "@eslint-community/mysticatea/node/no-process-env": "error",
+        "@eslint-community/mysticatea/node/no-process-exit": "error",
+        "@eslint-community/mysticatea/node/no-restricted-import": "error",
+        "@eslint-community/mysticatea/node/no-restricted-require": "error",
+        "@eslint-community/mysticatea/node/no-sync": "error",
         "@eslint-community/mysticatea/node/no-unpublished-bin": "error",
         "@eslint-community/mysticatea/node/no-unpublished-import": "error",
         "@eslint-community/mysticatea/node/no-unpublished-require": "error",

diff --git a/package.json b/package.json
@@ -17,7 +17,7 @@
         "@typescript-eslint/parser": "^5.40.0",
         "eslint-plugin-eslint-comments": "^3.2.0",
         "eslint-plugin-eslint-plugin": "^4.4.1",
-        "eslint-plugin-node": "^10.0.0",
+        "eslint-plugin-node": "^11.1.0",
         "eslint-plugin-prettier": "^3.4.1",
         "eslint-plugin-vue": "^6.2.2",
         "prettier": "^2.7.1",

diff --git a/tests/lib/configs/_rules.js b/tests/lib/configs/_rules.js
@@ -9,6 +9,7 @@ const {
     ConfigArrayFactory,
 } = require("eslint/lib/cli-engine/config-array-factory")
 const Validator = require("eslint/lib/shared/config-validator")
+const { rules: removedRules } = require("eslint/conf/replacements.json")
 const {
     rules: PluginRulesIndex,
 } = require("@eslint-community/eslint-plugin-mysticatea")
@@ -27,9 +28,7 @@ const deprecatedRuleNames = new Set(
         .filter(([, rule]) => rule && rule.meta && rule.meta.deprecated)
         .map(([ruleId]) => ruleId)
 )
-const removedRuleNames = new Set(
-    Object.keys(require("eslint/conf/replacements.json").rules)
-)
+const removedRuleNames = new Set(Object.keys(removedRules))
 
 const configFactory = new ConfigArrayFactory()
 

diff --git a/tests/lib/configs/browser.js b/tests/lib/configs/browser.js
@@ -5,11 +5,10 @@
  */
 "use strict"
 
+const config = require("../../../lib/configs/+browser")
 const Rules = require("./_rules")
 
 describe("'+browser.js'", () => {
-    const config = require("../../../lib/configs/+browser")
-
     it("should be a valid config.", () => {
         Rules.validateConfig(config, "+browser.js")
     })

diff --git a/tests/lib/configs/es2015.js b/tests/lib/configs/es2015.js
@@ -6,6 +6,7 @@
 "use strict"
 
 const assert = require("assert")
+const config = require("../../../lib/configs/es2015")
 const Rules = require("./_rules")
 
 /**
@@ -22,7 +23,6 @@ function isES6Rule(ruleId) {
 }
 
 describe("'es2015.js'", () => {
-    const config = require("../../../lib/configs/es2015")
     const configuredRules = Rules.getRulesOfConfig(config, "es2015")
     const existingRules = Rules.getCoreRuleNames()
 

diff --git a/tests/lib/configs/es2016.js b/tests/lib/configs/es2016.js
@@ -5,11 +5,10 @@
  */
 "use strict"
 
+const config = require("../../../lib/configs/es2016")
 const Rules = require("./_rules")
 
 describe("'es2016.js'", () => {
-    const config = require("../../../lib/configs/es2016")
-
     it("should be a valid config.", () => {
         Rules.validateConfig(config, "es2016.js")
     })

diff --git a/tests/lib/configs/es2017.js b/tests/lib/configs/es2017.js
@@ -5,11 +5,10 @@
  */
 "use strict"
 
+const config = require("../../../lib/configs/es2017")
 const Rules = require("./_rules")
 
 describe("'es2017.js'", () => {
-    const config = require("../../../lib/configs/es2017")
-
     it("should be a valid config.", () => {
         Rules.validateConfig(config, "es2017.js")
     })

diff --git a/tests/lib/configs/es2018.js b/tests/lib/configs/es2018.js
@@ -5,11 +5,10 @@
  */
 "use strict"
 
+const config = require("../../../lib/configs/es2018")
 const Rules = require("./_rules")
 
 describe("'es2018.js'", () => {
-    const config = require("../../../lib/configs/es2018")
-
     it("should be a valid config.", () => {
         Rules.validateConfig(config, "es2018.js")
     })

diff --git a/tests/lib/configs/es2019.js b/tests/lib/configs/es2019.js
@@ -4,11 +4,10 @@
  */
 "use strict"
 
+const config = require("../../../lib/configs/es2019")
 const Rules = require("./_rules")
 
 describe("'es2019.js'", () => {
-    const config = require("../../../lib/configs/es2019")
-
     it("should be a valid config.", () => {
         Rules.validateConfig(config, "es2019.js")
     })

diff --git a/tests/lib/configs/es2020.js b/tests/lib/configs/es2020.js
@@ -4,11 +4,10 @@
  */
 "use strict"
 
+const config = require("../../../lib/configs/es2020")
 const Rules = require("./_rules")
 
 describe("'es2020.js'", () => {
-    const config = require("../../../lib/configs/es2020")
-
     it("should be a valid config.", () => {
         Rules.validateConfig(config, "es2020.js")
     })

diff --git a/tests/lib/configs/es5.js b/tests/lib/configs/es5.js
@@ -6,6 +6,7 @@
 "use strict"
 
 const assert = require("assert")
+const config = require("../../../lib/configs/es5")
 const Rules = require("./_rules")
 
 /**
@@ -22,7 +23,6 @@ function isES6Rule(ruleId) {
 }
 
 describe("'es5.js'", () => {
-    const config = require("../../../lib/configs/es5")
     const configuredRules = Rules.getRulesOfConfig(config, "es5")
     const existingRules = [].concat(
         Rules.getCoreRuleNames(),

diff --git a/tests/lib/configs/eslint-plugin.js b/tests/lib/configs/eslint-plugin.js
@@ -6,10 +6,10 @@
 "use strict"
 
 const assert = require("assert")
+const config = require("../../../lib/configs/+eslint-plugin")
 const Rules = require("./_rules")
 
 describe("'+eslint-plugin.js'", () => {
-    const config = require("../../../lib/configs/+eslint-plugin")
     const configuredRules = Rules.getRulesOfConfig(config, "+eslint-plugin")
     const existingRules = Rules.getPluginRuleNames("eslint-plugin")
 

diff --git a/tests/lib/configs/mocha.js b/tests/lib/configs/mocha.js
@@ -5,11 +5,10 @@
  */
 "use strict"
 
+const config = require("../../../lib/configs/_override-mocha")
 const Rules = require("./_rules")
 
 describe("'mocha.js'", () => {
-    const config = require("../../../lib/configs/_override-mocha")
-
     it("should be a valid config.", () => {
         Rules.validateConfig(config, "mocha.js")
     })

diff --git a/tests/lib/configs/modules.js b/tests/lib/configs/modules.js
@@ -5,11 +5,10 @@
  */
 "use strict"
 
+const config = require("../../../lib/configs/+modules")
 const Rules = require("./_rules")
 
 describe("'+modules.js'", () => {
-    const config = require("../../../lib/configs/+modules")
-
     it("should be a valid config.", () => {
         Rules.validateConfig(config, "+modules.js")
     })

diff --git a/tests/lib/configs/node.js b/tests/lib/configs/node.js
@@ -6,10 +6,10 @@
 "use strict"
 
 const assert = require("assert")
+const config = require("../../../lib/configs/+node")
 const Rules = require("./_rules")
 
 describe("'+node.js'", () => {
-    const config = require("../../../lib/configs/+node")
     const configuredRules = Rules.getRulesOfConfig(config, "+node")
     const existingRules = Rules.getPluginRuleNames("node")
 

diff --git a/tests/lib/configs/special.js b/tests/lib/configs/special.js
@@ -5,11 +5,10 @@
  */
 "use strict"
 
+const config = require("../../../lib/configs/_override-special")
 const Rules = require("./_rules")
 
 describe("'special.js'", () => {
-    const config = require("../../../lib/configs/_override-special")
-
     it("should be a valid config.", () => {
         Rules.validateConfig(config, "special.js")
     })

diff --git a/tests/lib/configs/ts.js b/tests/lib/configs/ts.js
@@ -6,10 +6,10 @@
 "use strict"
 
 const assert = require("assert")
+const config = require("../../../lib/configs/_override-ts")
 const Rules = require("./_rules")
 
 describe("'ts.js'", () => {
-    const config = require("../../../lib/configs/_override-ts")
     const configuredRules = Rules.getRulesOfConfig(config, "_override-ts")
     const existingRules = Rules.getPluginRuleNames("ts")
 

diff --git a/tests/lib/configs/vue.js b/tests/lib/configs/vue.js
@@ -6,10 +6,10 @@
 "use strict"
 
 const assert = require("assert")
+const config = require("../../../lib/configs/_override-vue")
 const Rules = require("./_rules")
 
 describe("'vue.js'", () => {
-    const config = require("../../../lib/configs/_override-vue")
     const configuredRules = Rules.getRulesOfConfig(config, "_override-ts")
     const existingRules = Rules.getPluginRuleNames("vue")