feat: add require-meta-schema-description rule
#490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
force-pushed
the
require-meta-schema-description
branch
from
8e81ad3 to
69312a0
Compare
MichaelDeBoey
changed the title
require-meta-schema-description rule
MichaelDeBoey
approved these changes
Oct 19, 2024
bradzacher
approved these changes
Oct 20, 2024
Co-authored-by: Brad Zacher <[email protected]>
|
@JoshuaKGoldberg the ci was failing somehow, can you look please? |
|
Ah, I was missing some test coverage in the latest changes. Filled it in & used the |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #334.
This is a relatively straightforward approach that descends through the AST of
meta.schema. It doesn't attempt to dynamically construct the properties through AJV.I tried it out on typescript-eslint here: typescript-eslint/typescript-eslint#10171