Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add require-meta-docs-recommended rule #447

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Feb 17, 2024

Fixes #446.

Doesn't include any options, as the internal core ESLint no-invalid-meta rule doesn't require anything beyond existence.

lib/utils.js Outdated Show resolved Hide resolved
@aladdin-add
Copy link
Contributor

@JoshuaKGoldberg there is a few suggestions need to be addressed. friendly ping. :)

@JoshuaKGoldberg
Copy link
Contributor Author

D'oh, sorry! I completely missed the notification.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from bmish April 23, 2024 21:30
@bmish
Copy link
Member

bmish commented Apr 23, 2024

Looks like there are still conflicts.

@JoshuaKGoldberg
Copy link
Contributor Author

I'm finishing for the day, will fix the lint issue tomorrow.

@aladdin-add aladdin-add self-requested a review April 24, 2024 12:52
@aladdin-add
Copy link
Contributor

looks the ci was failing as the new release of eslint-doc-generator. I like to pin the version for better DX - as we don't have a lockfile.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from bmish April 24, 2024 20:10
@JoshuaKGoldberg JoshuaKGoldberg requested a review from bmish April 24, 2024 20:20
Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit 2370b46 into eslint-community:main Apr 25, 2024
6 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the require-meta-docs-recommended branch April 25, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule: require a meta.docs.recommended
3 participants