Allow additional types of dynamic schemas in require-meta-schema rule
#277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
reviewed
Aug 3, 2022
| 'MemberExpression', | ||
| 'ObjectExpression', | ||
| ].includes(value.type) | ||
| ) { |
There was a problem hiding this comment.
just wondering we can explicitly say what we want to check - as more expressions could be added in future es.
e.g some new added expressions:
- ChainExpression
- LogicalAssignmentExpression
There was a problem hiding this comment.
Yeah I'm worried about this too. I think I should update this to instead only check a few common invalid types like Literal.
There was a problem hiding this comment.
Switched to only checking for literals / null / undefined to be safe.
bmish
force-pushed
the
require-meta-schema-types
branch
from
f63c013 to
664128d
Compare
aladdin-add
approved these changes
Aug 4, 2022
bmish
added a commit
to bmish/eslint-plugin-eslint-plugin
that referenced
this pull request
Aug 4, 2022
* main: fix: clarify report messages for no-missing-placeholders and no-unused-placeholders (eslint-community#278) fix: allow additional schema types in require-meta-schema (eslint-community#277)
bmish
added a commit
to bmish/eslint-plugin-eslint-plugin
that referenced
this pull request
Aug 4, 2022
* main: fix: reporting location in no-missing-placeholders (eslint-community#280) fix: clarify report messages for no-missing-placeholders and no-unused-placeholders (eslint-community#278) fix: allow additional schema types in require-meta-schema (eslint-community#277)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to ban obviously-invalid types like
Literal(string/number) formeta.schema, while allowing any kind of variables/function calls/dynamic calculation of the schema.Previously, a simple variable was allowed, but now these are also allowed:
Fixes #273.