fix: improve eslint rule detecting

fixes #455
eslint-community · Apr 8, 2024 · 408f59a · 408f59a
1 parent 3d12851
commit 408f59a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/lib/utils.js b/lib/utils.js
@@ -3,17 +3,18 @@
 const { getStaticValue, findVariable } = require('eslint-utils');
 const estraverse = require('estraverse');
 
+const functionTypes = [
+  'FunctionExpression',
+  'ArrowFunctionExpression',
+  'FunctionDeclaration',
+];
+
 /**
  * Determines whether a node is a 'normal' (i.e. non-async, non-generator) function expression.
  * @param {ASTNode} node The node in question
  * @returns {boolean} `true` if the node is a normal function expression
  */
 function isNormalFunctionExpression(node) {
-  const functionTypes = [
-    'FunctionExpression',
-    'ArrowFunctionExpression',
-    'FunctionDeclaration',
-  ];
   return functionTypes.includes(node.type) && !node.generator && !node.async;
 }
 
@@ -152,9 +153,7 @@ function getRuleExportsESM(ast, scopeManager) {
           possibleNodes.push(
             ...nodes.filter(
               (node) =>
-                node &&
-                node.type !== 'FunctionDeclaration' &&
-                node.type !== 'FunctionExpression'
+                node && !functionTypes.includes(node.type)
             )
           );
         }

diff --git a/tests/lib/utils.js b/tests/lib/utils.js
@@ -91,6 +91,7 @@ describe('utils', () => {
         'export function foo(options) { return {}; }',
         'export async function foo(options) { return {}; }',
         'export const foo = function (options) { return {}; }',
+        'export const foo = (options) => { return {}; }',
         'export function foo(options) { return; }',
         'export function foo({opt1, opt2}) { return {}; }',