Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop CentOS #4314

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Drop CentOS #4314

merged 2 commits into from
Jul 4, 2024

Conversation

gustawlippa
Copy link
Contributor

@gustawlippa gustawlippa commented Jul 3, 2024

CentOS has reached End Of Life and because of that our builds started failing on CI. This PR gets rid of CentOS builds so that we can have green CI once again.

Manual run of GH Actions: https://github.com/esl/MongooseIM/actions/runs/9792072400

I changed the docs to reflect what we support, and updated the How to build MongooseIM from source page. The issue there is, that there is no erlang package in the official repositories, and the EPEL (a repository with additional packages) package is OTP22. The solutions I found on the internet of adding ESL repositories for rpm didn't work from me in a VM - I assume those are outdated. There is no better solution on our website, hence, the "manual" downloading of a newer package.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (e830b03) to head (8a89aed).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4314      +/-   ##
==========================================
- Coverage   84.30%   84.30%   -0.01%     
==========================================
  Files         553      553              
  Lines       33724    33724              
==========================================
- Hits        28432    28431       -1     
- Misses       5292     5293       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

Actually there is no Erlang package for Rocky Linux 8 out of the box, and the
EPEL package is OTP22. Since we don't support such an old version, we have to
download the package from the website.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 4, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 8a89aed
Reports root/ big
OK: 439 / Failed: 0 / User-skipped: 47 / Auto-skipped: 0


small_tests_25 / small_tests / 8a89aed
Reports root / small


small_tests_26 / small_tests / 8a89aed
Reports root / small


small_tests_26_arm64 / small_tests / 8a89aed
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 8a89aed
Reports root/ big
OK: 2289 / Failed: 0 / User-skipped: 905 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8a89aed
Reports root/ big
OK: 4573 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 8a89aed
Reports root/ big
OK: 2289 / Failed: 0 / User-skipped: 905 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 8a89aed
Reports root/ big
OK: 4540 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 8a89aed
Reports root/ big
OK: 4573 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 8a89aed
Reports root/ big
OK: 2429 / Failed: 0 / User-skipped: 765 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 8a89aed
Reports root/ big
OK: 4484 / Failed: 0 / User-skipped: 178 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 8a89aed
Reports root/ big
OK: 4570 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 8a89aed
Reports root/ big
OK: 4964 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 8a89aed
Reports root/ big
OK: 4964 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 8a89aed
Reports root/ big
OK: 4943 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 8a89aed
Reports root/ big
OK: 4961 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

@gustawlippa gustawlippa marked this pull request as ready for review July 4, 2024 10:04
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌 . Thanks for fixing the CI builds!

@chrzaszcz chrzaszcz merged commit 074de4f into master Jul 4, 2024
23 checks passed
@chrzaszcz chrzaszcz deleted the drop_centos branch July 4, 2024 12:00
@jacekwegr jacekwegr added this to the 6.3.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants