Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm scripts and wrap makefile around it #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gikari
Copy link

@gikari gikari commented Aug 26, 2021

Advantages:

  • Building description is more readable (top to bottom)
  • Build step is extracted from package step
  • Abstraction layers are not mixed within the tools ("Scripts describe
    how to build, Npm calls scripts, Make calls Npm" instead of "Make
    describes build, calls Npm")
  • No duplication of package description in Makefile and package.json

How to test

Run all make commands:

clean
build
run
start
stop
test
package
install
uninstall

Advantages:
- Building description is more readable (top to bottom)
- Build step is extracted from package step
- Abstraction layers are not mixed within the tools ("Scripts describe
  how to build, Npm calls scripts, Make calls Npm" instead of "Make
  describes build, calls Npm")
- No duplication of package description in Makefile and package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant