Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: MultilineElment text value won't update #694

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions quickdialog/QMultilineElement.m
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ @implementation QMultilineElement
- (QEntryElement *)init {
self = [super init];
if (self) {
self.presentationMode = QPresentationModePopover;
self.presentationMode = (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPhone)?QPresentationModeModalForm:QPresentationModePopover;
}

return self;
Expand All @@ -32,7 +32,7 @@ - (QMultilineElement *)initWithTitle:(NSString *)title value:(NSString *)text
{
if ((self = [super initWithTitle:title Value:nil])) {
self.textValue = text;
self.presentationMode = QPresentationModePopover;
self.presentationMode = (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPhone)?QPresentationModeModalForm:QPresentationModePopover;
}
return self;
}
Expand Down Expand Up @@ -68,7 +68,7 @@ - (void)selected:(QuickDialogTableView *)tableView controller:(QuickDialogContro
__weak QMultilineTextViewController *weakTextController = textController;
textController.willDisappearCallback = ^ {
weakSelf.textValue = weakTextController.textView.text;
[[tableView cellForElement:weakSelf] setNeedsDisplay];
[tableView reloadRowsAtIndexPaths:@[indexPath] withRowAnimation:NO];
[tableView deselectRowAtIndexPath:indexPath animated:YES];
};
[controller displayViewController:textController withPresentationMode:self.presentationMode];
Expand Down