Some feedback on getBalanceAll implementation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnicbear
commented
Apr 11, 2022
|
|
||
| async.each(requests, getServerWithAuthWrapper, cb2); | ||
| // return a list of promises that we can await or chain |
There was a problem hiding this comment.
it's not particularly necessary to do this (you can alternatively return a Promise.all), but this way is slightly more efficient
There was a problem hiding this comment.
(However, we'd need to resolve a representation of any error, which is kind of weird)
picnicbear
commented
Apr 11, 2022
|
|
||
| try { | ||
| responses = await Promise.all( | ||
| getServerWithMultiAuth(req, res, opts).map(promise => |
There was a problem hiding this comment.
my bad, we don't need to pass opts here
Ellajoke
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You don't have to use these commits (I included a lot of comments and I haven't tested it with my changes yet)
But I think leveraging inheritance more in the bulk client class would be good
And most of the other updates are more stylistic or minute optimizations, so feel free to take or leave them