Skip to content

Commit

Permalink
fix(core): eslint and nx installation issues
Browse files Browse the repository at this point in the history
Signed-off-by: Emilien Escalle <[email protected]>
  • Loading branch information
neilime committed Aug 30, 2024
1 parent 88607c1 commit 44bef47
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 53 deletions.
24 changes: 0 additions & 24 deletions packages/core/src/__snapshots__/core.spec.e2e.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -12,30 +12,6 @@ Migration "core - 20240329200200-eslint-ignore" applied!
Applying migration "core - 20240412185500-eslint-config"...
Migration "core - 20240412185500-eslint-config" applied!
Applying migration "core - 20240617094000-config-nx-scopes"...
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Saved lockfile.
success Saved 2 new dependencies.
info Direct dependencies
├─ @commitlint/[email protected]
└─ @ts-dev-tools/[email protected]
info All dependencies
├─ @commitlint/[email protected]
└─ @ts-dev-tools/[email protected]
$ ts-dev-tools install
Updating ts-dev-tools installation...
Applying migration "core - 20240617094000-config-nx-scopes"...
Migration "core - 20240617094000-config-nx-scopes" applied!
Symlinking dev dependencies...
Symlinking dev dependencies done!
Checking for duplicate dev dependencies...
Some dev dependencies are unnecessarily installed as their are already required by "@ts-dev-tools/core":
- typescript
Check for duplicate dev dependencies done!
Installation done!
Migration "core - 20240617094000-config-nx-scopes" applied!
Symlinking dev dependencies...
Symlinking dev dependencies done!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ export const up: MigrationUpFunction = async (absoluteProjectDir: string): Promi

FileService.putFileContent(
eslintConfigFilePath,
`import tsDevToolsCore from "@ts-dev-tools/core/dist/eslint-plugin-ts-dev-tools/index.js";
`import { default as tsDevToolsCore } from "@ts-dev-tools/core/dist/eslint-plugin-ts-dev-tools/index.js";
export default tsDevToolsCore;
export default tsDevToolsCore.default;
`
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ exports[`Migration 20240412185500-eslint-config Up should apply migration 1`] =
`;

exports[`Migration 20240412185500-eslint-config Up should apply migration 2`] = `
"import tsDevToolsCore from "@ts-dev-tools/core/dist/eslint-plugin-ts-dev-tools/index.js";
"import { default as tsDevToolsCore } from "@ts-dev-tools/core/dist/eslint-plugin-ts-dev-tools/index.js";
export default tsDevToolsCore;
export default tsDevToolsCore.default;
"
`;
2 changes: 1 addition & 1 deletion packages/core/src/services/PackageManagerService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export class PackageManagerService {

args.push(packageName);

await PackageManagerService.execCommand(args, dirPath);
await PackageManagerService.execCommand(args, dirPath, true);
}

static async isMonorepo(dirPath: string) {
Expand Down
24 changes: 0 additions & 24 deletions packages/react/src/__snapshots__/react.spec.e2e.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -16,30 +16,6 @@ Migration "core - 20240412185500-eslint-config" applied!
Applying migration "react - 20240412185501-eslint-config"...
Migration "react - 20240412185501-eslint-config" applied!
Applying migration "core - 20240617094000-config-nx-scopes"...
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Saved lockfile.
success Saved 2 new dependencies.
info Direct dependencies
├─ @commitlint/[email protected]
└─ @ts-dev-tools/[email protected]
info All dependencies
├─ @commitlint/[email protected]
└─ @ts-dev-tools/[email protected]
$ ts-dev-tools install
Updating ts-dev-tools installation...
Applying migration "core - 20240617094000-config-nx-scopes"...
Migration "core - 20240617094000-config-nx-scopes" applied!
Symlinking dev dependencies...
Symlinking dev dependencies done!
Checking for duplicate dev dependencies...
Some dev dependencies are unnecessarily installed as their are already required by "@ts-dev-tools/core":
- typescript
Check for duplicate dev dependencies done!
Installation done!
Migration "core - 20240617094000-config-nx-scopes" applied!
Symlinking dev dependencies...
Symlinking dev dependencies done!
Expand Down

0 comments on commit 44bef47

Please sign in to comment.