This repository has been archived by the owner on Oct 19, 2023. It is now read-only.
update to latest handlebars #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like your build is suffering from the same problem that I hit when trying to update to the latest Handlebars: https://travis-ci.org/epeli/node-hbsfy/jobs/16128059 "Unexpected identifier" I tried to track it down as part of #8, but couldn't figure out why it was happening. |
|
The runtime api in handlebars changed (it wasn't a public api untll now). See handlebars-lang/handlebars.js#668 I did some work for it in here https://github.com/epeli/node-hbsfy/compare/hbs12 but something still fails https://travis-ci.org/epeli/node-hbsfy/jobs/16517065 I'll fix it in few days. Just posting it here if anyone wants to go ahead and fix it early :) |
esamattis
added a commit
that referenced
this pull request
Jan 15, 2014
Just update the bundle size in tests Closes #9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to handlebars 1.2.x. All tests pass.