Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Image count visible in the folder mode when moved from one folder to another #410

Merged
merged 3 commits into from
Oct 23, 2022

Conversation

kavitamp
Copy link
Contributor

Issue:

Fix the image count issue in the toolbar when the folder mode is selected.

Description and steps:

Image count is not showing properly in the folder mode when moved from one folder to another.
Steps:

  1. Enable folder mode
  2. Open Custom Ui image picker
  3. Select any number of images and click back
  4. Open another folder
  5. The toolbar shows "Folder" instead of image count

Expected behavior:

When opening different folders, the topbar should display the selected image count.

Issue recording:

Selected-Images-Count-Issue.mp4

Fixed issue recording:

Selected-Images-Count-Fixed.mp4

Please let me know if you have any feedback.
Thank you!

@kavitamp kavitamp changed the title Image count is not showing properly in the folder mode when moved from one folder to another BugFix: Image count visible in the folder mode when moved from one folder to another Oct 18, 2022
@esafirm
Copy link
Owner

esafirm commented Oct 23, 2022

@kavitamp Nice fix! Will merge once the CI working correctly

@esafirm esafirm force-pushed the fix-image-count-issue-in-app-bar branch from 52bc92b to 65a78e2 Compare October 23, 2022 15:41
@esafirm esafirm force-pushed the fix-image-count-issue-in-app-bar branch from da17e7b to 23baf2a Compare October 23, 2022 16:46
@esafirm esafirm merged commit 5979023 into esafirm:main Oct 23, 2022
@esafirm
Copy link
Owner

esafirm commented Oct 25, 2022

Close #410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants