-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbar Done button visibility. #347
Conversation
…ton always or not.
@@ -40,4 +40,8 @@ object ConfigUtils { | |||
val doneButtonText = config.doneButtonText | |||
return if (doneButtonText.isNullOrBlank()) context.getString(R.string.ef_done) else doneButtonText | |||
} | |||
|
|||
fun getDoneButtonTextVisibility(config: ImagePickerConfig): Boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need helper function if it just accessing a property
@@ -7,4 +7,5 @@ abstract class BaseConfig { | |||
abstract var savePath: ImagePickerSavePath | |||
abstract var returnMode: ReturnMode | |||
abstract var isSaveImage: Boolean | |||
abstract var showDoneButtonAlways: Boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should only add this in ImagePickerConfig
since it's not affecting CameraOnly
functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated code as per your request.
@esafirm Can you please have a look at my pr as this is blocker to my release. thanks in advance. |
LGTM 👍 Thanks for the PR @dilip786 |
Packagin this as |
Thanks Esafirm/Android-Image-Picker
…On Thu, 8 Apr, 2021, 7:51 am Esa Firman, ***@***.***> wrote:
Packagin this as 3.0.0-alpha2 @dilip786 <https://github.com/dilip786>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#347 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACRKBYCK3WHEUT4PSCZR7V3THUHJPANCNFSM42INRCYA>
.
|
The artifact is now |
Can it be released also as part of the v2 release train? Thank you @esafirm 🥇 |
* Added a new variable in ImagePickerConfig.kt Whether to show Done button always or not. * Code cleanup
Added a new variable in ImagePickerConfig.kt Whether to show Done button or not always, We already had a chat on this and here is the bug link [(https://github.com//issues/339 )].
This is blocker to my release, Please have a look and let me know if you need any changes.