Added zipcode and birthdate to event signup export (issue #300)

[ThijsEgberts]

Added zipcode and birthdate to event signup export
#300

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 30.06%. Comparing base (5284624) to head (8d1c5b5).

Files with missing lines	Patch %	Lines
app/Services/AgendaApplicationFormService.php	0.00%	3 Missing ⚠️
app/Exports/AgendaRegistrationExport.php	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #396      +/-   ##
============================================
- Coverage     30.13%   30.06%   -0.08%     
  Complexity      529      529              
============================================
  Files            80       80              
  Lines          2014     2019       +5     
============================================
  Hits            607      607              
- Misses         1407     1412       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[marijnvanderhorst]

I'd suggest performing this attribute formatting in the User model instead. There, we can firsts add

protected $casts = [
    'birthDay' => 'date',
];

This will ensure the birthDay attribute is always type-casted to a Carbon instance.

Then, I'd suggest defining an accessor to retrieve the "formatted birthday", as follows.

public function birthdayFormatted(): Attribute
{
    return Attribute::make(
        get: fn () => $this->birthDay->format('Y-m-d'),
    );
}

Note that the formatted birthday value can now simply be retrieved using $user->birthdayFormatted (not calling the function, but relying on the new property that will be magically added by the framework) or $user['birthdayFormatted'] whenever we have an instance of the user model.

[marijnvanderhorst]

Then, this would need to be changed to the birthdayFormatted property instead.