Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove localization, set english as default #348

Merged
merged 44 commits into from
Oct 19, 2023
Merged

Conversation

wouterbles
Copy link
Contributor

@wouterbles wouterbles commented Oct 10, 2023

Removes localizaton (texts) feature from the website. Makes it easier to keep content uptodate and decreases complexity of the codebase.

  • This also adds migrations to set the EN value from the texts table to the original column that had referenced the texts table by foreign key
  • Migrations have been tested locally with production version of the database and work correctly
  • Removes most of the 'lang' files, as these had very inconsistent translations and replaced the trans() instances to the actual vaules

@wouterbles wouterbles temporarily deployed to Build October 11, 2023 13:41 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #348 (d56faee) into master (8890c73) will decrease coverage by 3.99%.
The diff coverage is 24.04%.

❗ Current head d56faee differs from pull request most recent head 0f66f1a. Consider uploading reports for the commit 0f66f1a to get more accurate results

@@             Coverage Diff              @@
##             master     #348      +/-   ##
============================================
- Coverage     35.10%   31.12%   -3.99%     
+ Complexity      561      526      -35     
============================================
  Files            87       80       -7     
  Lines          2162     1960     -202     
============================================
- Hits            759      610     -149     
+ Misses         1403     1350      -53     
Files Coverage Δ
app/Console/Commands/RemoveOldApplications.php 100.00% <100.00%> (ø)
app/Console/Commands/RemoveOldUsers.php 100.00% <100.00%> (ø)
app/CustomClasses/MailList/MailListMember.php 0.00% <ø> (ø)
app/Http/Controllers/PendingUserController.php 81.25% <100.00%> (ø)
app/Http/Middleware/Authorize.php 100.00% <100.00%> (ø)
app/Http/Requests/ApplicationFormStoreRequest.php 100.00% <100.00%> (ø)
app/MenuItem.php 27.58% <ø> (-6.70%) ⬇️
app/Models/ApplicationForm/ApplicationForm.php 100.00% <100.00%> (ø)
app/Models/ApplicationForm/ApplicationFormRow.php 100.00% <ø> (ø)
app/Models/ApplicationForm/ApplicationResponse.php 50.00% <ø> (ø)
... and 67 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wouterbles wouterbles temporarily deployed to Build October 11, 2023 15:16 — with GitHub Actions Inactive
@wouterbles wouterbles temporarily deployed to Build October 11, 2023 20:45 — with GitHub Actions Inactive
@wouterbles wouterbles temporarily deployed to Build October 18, 2023 08:52 — with GitHub Actions Inactive
@wouterbles wouterbles temporarily deployed to Build October 18, 2023 09:07 — with GitHub Actions Inactive
@wouterbles wouterbles temporarily deployed to Build October 18, 2023 10:23 — with GitHub Actions Inactive
@wouterbles wouterbles temporarily deployed to Build October 18, 2023 11:20 — with GitHub Actions Inactive
@wouterbles wouterbles temporarily deployed to Build October 18, 2023 11:23 — with GitHub Actions Inactive
@wouterbles wouterbles temporarily deployed to Build October 18, 2023 17:45 — with GitHub Actions Inactive
@wouterbles wouterbles temporarily deployed to Build October 19, 2023 07:50 — with GitHub Actions Inactive
@wouterbles wouterbles temporarily deployed to Build October 19, 2023 10:06 — with GitHub Actions Inactive
@wouterbles wouterbles temporarily deployed to Build October 19, 2023 11:28 — with GitHub Actions Inactive
@wouterbles wouterbles merged commit 8da73b9 into master Oct 19, 2023
2 checks passed
@wouterbles wouterbles deleted the english-default branch October 23, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant