-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft PR for using the new iterator #48
Draft
davidamarquis
wants to merge
16
commits into
dev
Choose a base branch
from
usenewgray
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or information set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for review, just posting this to keep track of benchmarks.
I'm done with Julia-based optimizations for now. There are some other optimizations White describes in Ch7 that I would like to do but that would be in a future PR.
Remaining tasks for this PR
Reduce matrix size by excluding identity submatrix from the enumeration
Make new approach multithreaded
Benchmarks
The benchmarks here use the code in
benchmarks/weight_dist_bench.jl
n=70
k=35
Code used is the code of largest distance that is known for [n, k]
Nov 18 Benchmarks (1 thread)
Old approach which uses matrix mulitiplies
Time ~ 3.7s
Memory ~ 62 MiB
New approach
Time ~ 10.7 msTime ~ 335ms [Edit: earlier today posted 10.7 ms but there was a mistake because of a line of code Id left in that was meant for Zimmerman's algorithm, not for Brouwer's.]Memory ~ 480 KiB
So new approach is about 11 times faster [updated].