Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS Review] Fix Python syntax of minimal example #20

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

santisoler
Copy link
Contributor

Fix the Python syntax of the minimal example in the README.py. Add a trailing comma to the computation_points argument when calling polyhedral_gravity.evaluate().


This PR is part of the JOSS review: openjournals/joss-reviews#6384

Fix the Python syntax of the minimal example in the `README.py`. Add
a trailing comma to the `computation_points` argument when calling
`polyhedral_gravity.evaluate()`.
Copy link
Collaborator

@schuhmaj schuhmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typical mistake: missing commas 🙃 👍

@schuhmaj schuhmaj merged commit 0e31ec3 into esa:main Mar 13, 2024
3 checks passed
@santisoler santisoler deleted the fix-example branch March 13, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants