Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Function.prototype.apply to work with generic array-like object instead of an array #100

Closed
wants to merge 2 commits into from
Closed

Fix Function.prototype.apply to work with generic array-like object instead of an array #100

wants to merge 2 commits into from

Conversation

termi
Copy link
Contributor

@termi termi commented Feb 2, 2012

Function.prototype.apply shim:

  • allow Object as second parameter
  • allow DOM Object (NodeList, etc) as second parameter
  • avoid using String as second parameter
  • 3 Tests

termi added 2 commits February 1, 2012 12:25
@termi
+ [Draft] Fix Function.prototype.apply to work with generic array-lik…
a1cc509 
…e object instead of an array

+ tests for Function.prototype.apply
@termi
Function.prototype.apply shim:
37fb432 
+ allow Object as second parameter
+ allow DOM Object (NodeList, etc) as second parameter
* avoid using String as second parameter
+ 3 Tests
@termi
Copy link
Contributor Author

termi commented Feb 2, 2012

Fix #99

@termi
Copy link
Contributor Author

termi commented Feb 9, 2012

Found a bug. Went write test case

@termi termi closed this Feb 9, 2012
@termi termi mentioned this pull request Oct 12, 2012
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@termi