Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken in IE8 #253

Closed
jamietre opened this issue Jun 24, 2014 · 4 comments
Closed

Broken in IE8 #253

jamietre opened this issue Jun 24, 2014 · 4 comments

Comments

@jamietre
Copy link

You try to use indexOf before polyfilling it.

var hasFirefox2IndexOfBug = [0, 1].indexOf(1, 2) !== -1;   // fails in IE8
defineProperties(ArrayPrototype, {
    indexOf: function indexOf(sought /*, fromIndex */ ) {
@ljharb
Copy link
Member

ljharb commented Jun 24, 2014

Thanks for catching this!

@ljharb ljharb closed this as completed in 74e3640 Jun 24, 2014
@ljharb
Copy link
Member

ljharb commented Jun 24, 2014

Note that this bug is not in the released v3.4.0, so nobody should have been impacted by this yet.

@jamietre
Copy link
Author

Thanks for the quick update!

By the way - running the tests in IE8 I noticed that after patching this issue there are still 65 failures, same as the official release - is this expected? I noticed some very old commentary about IE8 tests failing but wasn't sure if that discussion was still current.

@ljharb
Copy link
Member

ljharb commented Jun 24, 2014

Yes, per #114 - IE 6-8 have a JS engine bug that makes some of the tests (specifically anything relating to sparse arrays) from ever passing.

@bengourley bengourley mentioned this issue Jun 25, 2014
Merged
Krinkle pushed a commit to wikimedia/mediawiki that referenced this issue Jul 10, 2014
@plstand @Krinkle
Update es5-shim to latest master (40181d720e07)
61c81de 
Includes a fix for <es-shims/es5-shim#253>.
The bug makes es5-shim unusable in the browsers we are most interested
in using it for: old versions of IE.

Source code:
 https://github.com/es-shims/es5-shim/blob/40181d720e/es5-shim.js

Bug: 67565
Change-Id: Iee964bea6fcc1071871e457643b77ffd452e1040
wmfgerrit pushed a commit to wikimedia/mediawiki that referenced this issue Jul 10, 2014
@plstand @jdforrester
Update es5-shim to latest master (40181d720e07)
e496772 
Includes a fix for <es-shims/es5-shim#253>.
The bug makes es5-shim unusable in the browsers we are most interested
in using it for: old versions of IE.

Source code:
 https://github.com/es-shims/es5-shim/blob/40181d720e/es5-shim.js

Bug: 67565
Change-Id: Iee964bea6fcc1071871e457643b77ffd452e1040
(cherry picked from commit 61c81de)
wmfgerrit pushed a commit to wikimedia/mediawiki that referenced this issue Jul 10, 2014
@plstand @jdforrester
Update es5-shim to latest master (40181d720e07)
5a0db50 
Includes a fix for <es-shims/es5-shim#253>.
The bug makes es5-shim unusable in the browsers we are most interested
in using it for: old versions of IE.

Source code:
 https://github.com/es-shims/es5-shim/blob/40181d720e/es5-shim.js

Bug: 67565
Change-Id: Iee964bea6fcc1071871e457643b77ffd452e1040
(cherry picked from commit 61c81de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @jamietre