Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Versions attached to @api-see now follow through #33

Merged
merged 2 commits into from
Feb 25, 2017

Conversation

erunion
Copy link
Owner

@erunion erunion commented Feb 25, 2017

This fixes an issue with @api-version usage when used on @api-see annotations, where the following would not add the supplied version to the also supplied see:

/**
 * @api-label Play representation
 * @api-field play
 * @api-type representation
 * @api-version >=3.3
 * @api-see \PlayResponse::_json play
 */

Now, with this, play is under >=3.3, as well as everything within \PlayResponse::_json.

I also added some improved assertions in a few tests, moving them away from count assertions and onto direct array key comparisons, making it loads easier to debug failures.

Fixes #30.

@erunion erunion added this to the v1.4 milestone Feb 25, 2017
@erunion erunion self-assigned this Feb 25, 2017
@erunion erunion merged commit 66ad4cc into 1.4-dev Feb 25, 2017
@erunion erunion deleted the api-version-with-see branch February 25, 2017 04:52
@erunion erunion modified the milestone: v1.4 Feb 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant