-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to create annotations; printing Vale alerts instead for PRs #12
Comments
See https://github.com/errata-ai/vale-action#limitations. I believe Problem Matchers are the correct way to handle this now, though (which weren't documented yet when I wrote this action). |
Hey there! The readme on the repo suggests using
Should the master be discarded for linting? Please confirm. To add more to the above. If I don't use
|
The two branches are different versions that have different features. I recommend using the |
Here's a fixed link to the historical "Limitations" section of the readme that @jdkato mentions above https://github.com/errata-ai/vale-action/blob/v1.2.0/README.md#limitations |
Currently when the lint action runs it produces this error Unable to create annotations; printing Vale alerts instead. This is caused by errata-ai/vale-action#12 To fix this, the author recommends using the `reviewdog` branch. This commit sets the GitHub Action to that branch. Signed-off-by: Gene Wood <[email protected]>
In the current version of vale-action the featurs are different 1. There's no need to indicate where the CONFIG file is as .vale.ini is in the correct location by default 2. This new version no longer supports the `__onlyModified` flag so I've removed it. This does mean that the vale check will now check the whole repo. If this is a problem then we'll want to go back to the older version and live with the `Unable to create annotations; printing Vale alerts instead.` error ( errata-ai/vale-action#12 ) Signed-off-by: Gene Wood <[email protected]>
I'm using Vale on my documentation repository at https://github.com/vendrhub/vendr-documentation/ and all seems to work fine when I make commits to the core repository myself, however, for people submitting PR's it appears that Vale fails to create annotations and instead just prints the errors out to the console instead.
https://github.com/vendrhub/vendr-documentation/pull/14/checks?check_run_id=632785607
Is there something amiss in my config as to why this is the case?
/Matt
The text was updated successfully, but these errors were encountered: