Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create annotations; printing Vale alerts instead for PRs #12

Open
mattbrailsford opened this issue Apr 30, 2020 · 4 comments
Open
Labels
enhancement New feature or request question Further information is requested

Comments

@mattbrailsford
Copy link

I'm using Vale on my documentation repository at https://github.com/vendrhub/vendr-documentation/ and all seems to work fine when I make commits to the core repository myself, however, for people submitting PR's it appears that Vale fails to create annotations and instead just prints the errors out to the console instead.

https://github.com/vendrhub/vendr-documentation/pull/14/checks?check_run_id=632785607

Is there something amiss in my config as to why this is the case?

/Matt

@jdkato jdkato added the question Further information is requested label May 1, 2020
@jdkato
Copy link
Member

jdkato commented May 1, 2020

See https://github.com/errata-ai/vale-action#limitations.

I believe Problem Matchers are the correct way to handle this now, though (which weren't documented yet when I wrote this action).

@jnikhila
Copy link

jnikhila commented Nov 18, 2022

Hey there! The readme on the repo suggests using errata-ai/vale-action@reviewdog for linitng. If I change it to errata-ai/vale-action@master instead of errata-ai/vale-action@reviewdog then I start getting the below error:

Annotations
1 warning
Unable to create annotations; printing Vale alerts instead.

Should the master be discarded for linting? Please confirm.

To add more to the above. If I don't use master - the properties onlyAnnotateModifiedLines and __onlyModified are considered invalid.

  • Unexpected input(s) 'onlyAnnotateModifiedLines', valid inputs are ['entryPoint', 'args', 'version', 'files', 'debug', 'reporter', 'fail_on_error', 'level', 'filter_mode', 'vale_flags', 'separator']
  • User-specified path (__onlyModified) is invalid; falling back to 'all'.

@jdkato
Copy link
Member

jdkato commented Nov 22, 2022

The two branches are different versions that have different features. I recommend using the reviewdog branch so that you can Vale CLI updates, but the other can still be used.

@gene1wood
Copy link

Here's a fixed link to the historical "Limitations" section of the readme that @jdkato mentions above

https://github.com/errata-ai/vale-action/blob/v1.2.0/README.md#limitations

gene1wood added a commit to gene1wood/chef-web-docs that referenced this issue Feb 1, 2023
Currently when the lint action runs it produces this error

Unable to create annotations; printing Vale alerts instead.

This is caused by errata-ai/vale-action#12

To fix this, the author recommends using the `reviewdog` branch. This commit sets the GitHub Action to that branch.

Signed-off-by: Gene Wood <[email protected]>
gene1wood added a commit to gene1wood/chef-web-docs that referenced this issue Feb 1, 2023
In the current version of vale-action the featurs are different

1. There's no need to indicate where the CONFIG file is as .vale.ini is in the correct location by default

2. This new version no longer supports the `__onlyModified` flag so I've removed it. This does mean that the vale check will now check the whole repo. If this is a problem then we'll want to go back to the older version and live with the `Unable to create annotations; printing Vale alerts instead.` error ( errata-ai/vale-action#12 )

Signed-off-by: Gene Wood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants