Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved translation for NB - Norsk Bokmål #692

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

magnulu
Copy link

@magnulu magnulu commented Nov 22, 2024

Cleaned up the translation, IMO making it better. Also added translations for one_liner's and FreeCBT-specific stuff.

@magnulu
Copy link
Author

magnulu commented Nov 22, 2024

(How) can I build an android apk to test that everything is right?. First time contributor here, and can't find the answer from searching :)

@erosson
Copy link
Owner

erosson commented Nov 26, 2024

Awesome, thank you so much! Merging now, and it should appear in the app in the next day or two, without an appstore update. Make sure you kill and restart your app to see it.

(How) can I build an android apk to test that everything is right?.

I don't expect translators to do this! Appreciate your thoroughness all the same, though.

The automated tests attached to this pull request are the main check for correctness. I also run things on my machine before merging, mostly just seeing if translations appear at all.

https://github.com/erosson/freecbt/blob/master/CONTRIBUTING.md should have docs for building/running the project - but it uses expo's dev kit, not a local apk, and it's a little out of date. Short version of how I develop things:

# Run the project's devcontainer in vscode. it's a docker container with pre-installed dependencies like node/yarn/expo/android tools

yarn
yarn start

# After `yarn start`, an Expo server is running. 
# Run the Expo client on your phone, connect to the server, and see the app. 

@erosson erosson merged commit b62dfc1 into erosson:master Nov 26, 2024
1 check passed
erosson added a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants