Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discovery server not stopping properly #38

Merged
merged 2 commits into from
Apr 5, 2018

Conversation

ernoaapa
Copy link
Owner

@ernoaapa ernoaapa commented Apr 5, 2018

Previously discovery.Server hang if Stop() were called and never actually close. There were missing make(chan).

ernoaapa added 2 commits April 5, 2018 14:04
Previously discovery.Server hang if Stop() were called and never
actually close. There were missing make(chan).
@codecov
Copy link

codecov bot commented Apr 5, 2018

Codecov Report

Merging #38 into master will increase coverage by 1.45%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   24.02%   25.48%   +1.45%     
==========================================
  Files          50       50              
  Lines        2439     2433       -6     
==========================================
+ Hits          586      620      +34     
+ Misses       1789     1746      -43     
- Partials       64       67       +3
Impacted Files Coverage Δ
pkg/discovery/server.go 90.9% <100%> (+90.9%) ⬆️
pkg/discovery/client.go 77.77% <75%> (+77.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ace815...34ddabd. Read the comment docs.

@ernoaapa ernoaapa merged commit f3fd627 into master Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant