Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'eli describe node' to print mounts in human-readable sizes #36

Merged
merged 1 commit into from
Apr 28, 2018

Conversation

ernoaapa
Copy link
Owner

Previously eli describe node were printing just mount sizes
in bytes. This wasn't really user-friendly and "human-readable" as it
should so update the output to print the sizes in GB, MB, etc.

Previously `eli describe node` were printing just bytes of mount
sizes. This wasn't really user friendly and "human-readable" as it
should so updated the output to print the sizes in GB, MB, etc.
@ernoaapa ernoaapa force-pushed the humanreadable-mount-sizes branch from 47eb74b to 89992ba Compare April 28, 2018 13:41
@codecov
Copy link

codecov bot commented Apr 28, 2018

Codecov Report

Merging #36 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   25.17%   25.26%   +0.09%     
==========================================
  Files          50       50              
  Lines        2415     2418       +3     
==========================================
+ Hits          608      611       +3     
  Misses       1740     1740              
  Partials       67       67
Impacted Files Coverage Δ
pkg/printers/humanreadable.go 56.25% <100%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db5d4a4...89992ba. Read the comment docs.

@ernoaapa ernoaapa merged commit 5c72763 into master Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant