Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated containerd to v1.0.2 with fix "Fix pull-multi-arch images for Arm #35

Merged
merged 2 commits into from
Mar 25, 2018

Conversation

ernoaapa
Copy link
Owner

We want to start follow stable releases of containerd, but there's
one fix containerd/containerd#1575 which
prevents pulling images on ARM.
Switched to use custom containerd version which is
v1.0.2 with Weichen81:arm-multi-arch fix.

…rchitecture

Previously user got "manifest xyz not found" error when trying to
start an contianer because the image didn't support the target architecture.

Now before we try to unpack the image, we check does it support
the given architecture.
… Arm"

We want to start follow stable releases of containerd, but there's
one fix containerd/containerd#1575 which
prevents pulling images on ARM.
Switched to use custom containerd version which is
v1.0.2 with Weichen81:arm-multi-arch fix.
@codecov
Copy link

codecov bot commented Mar 25, 2018

Codecov Report

Merging #35 into master will increase coverage by 0.04%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   23.97%   24.02%   +0.04%     
==========================================
  Files          50       50              
  Lines        2419     2439      +20     
==========================================
+ Hits          580      586       +6     
- Misses       1775     1789      +14     
  Partials       64       64
Impacted Files Coverage Δ
pkg/runtime/errors.go 100% <ø> (ø) ⬆️
pkg/runtime/containerd.go 1.73% <27.27%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d7e51...88ffdaa. Read the comment docs.

@ernoaapa ernoaapa merged commit ec2d98b into master Mar 25, 2018
@ernoaapa ernoaapa deleted the unsupported-arch branch March 25, 2018 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant