Add more info to 'eli describe device <name>' #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were calling target computer as "device" which is more familiar name for IoT computers, "devices". But in future we want to bring the attached devices (sensors, usb devices, harddrives) into the model so "Device" name were conflicting with it. Renamed Device concept to Node as it is in Kubernetes so we can use Device to describe attached devices.
So if some information changes over time, the information get updated.
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 19.94% 23.97% +4.02%
==========================================
Files 49 50 +1
Lines 2346 2419 +73
==========================================
+ Hits 468 580 +112
+ Misses 1825 1775 -50
- Partials 53 64 +11
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added filesystem and uptime information to
eli describe devicecommand.Also under the hood renamed concept of
DevicetoNodebecause in future we want to call attached devices as "devices" and follow same naming convention as Kubernetes about the actual device where containers run, as "nodes".