Cleanup golint issues

cmd/eli/createPodCommand.go

@@ -66,9 +66,6 @@ var createPodCommand = cli.Command{
 		defer writer.Flush()
 		printer := cmd.GetPrinter(clicontext)
 
-		if err := printer.PrintPod(result, writer); err != nil {
-			return err
-		}
-		return nil
+		return printer.PrintPod(result, writer)
 	},
 }

pkg/cmd/ui/debug.go

@@ -12,6 +12,7 @@ func NewDebug() *Debug {
 	return debug
 }
 
+// Start starts updating the terminal lines
 func (t *Debug) Start() {
 	t.running = true
 }

pkg/cmd/ui/line.go

@@ -1,5 +1,6 @@
 package ui
 
+// Line represents single ine in terminal output
 type Line interface {
 	WithProgress(current, total int64) Line
 	Infof(format string, args ...interface{}) Line

pkg/cmd/ui/terminal.go

@@ -19,7 +19,7 @@ type Terminal struct {
 }
 
 // NewTerminal creates new Terminal UI which prints
-// output to the
+// output to the os.Stdout
 func NewTerminal() *Terminal {
 	terminal := &Terminal{
 		writer: goterminal.New(os.Stdout),
@@ -29,6 +29,7 @@ func NewTerminal() *Terminal {
 	return terminal
 }
 
+// Start starts updating the terminal lines
 func (t *Terminal) Start() {
 	t.running = true
 	go func() {
@@ -68,7 +69,7 @@ func (t *Terminal) NewLine() Line {
 	t.mtx.Lock()
 	defer t.mtx.Unlock()
 
-	row := &TerminalLine{updater: t}
+	row := &TerminalLine{terminal: t}
 	t.rows = append(t.rows, row)
 	return row
 }

pkg/cmd/ui/terminal/progress.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 )
 
+// Bar presents progress bar
 type Bar struct {
 	// Fill is the default character representing completed progress
 	Fill byte

pkg/cmd/ui/terminal/spinner.go

@@ -2,6 +2,7 @@ package terminal
 
 import "github.com/ernoaapa/eliot/pkg/utils"
 
+// Spinner is loading spinner which on each rotation moves spinner around
 type Spinner struct {
 	frames []string
 }

pkg/cmd/ui/terminalline.go

@@ -9,10 +9,6 @@ import (
 	"github.com/willf/pad"
 )
 
-type Updater interface {
-	Update()
-}
-
 // State of the line
 type State int
 
@@ -31,7 +27,7 @@ const (
 
 // TerminalLine is single text line in the terminal output what you can change afterward
 type TerminalLine struct {
-	updater      Updater
+	terminal     *Terminal
 	state        State
 	Text         string
 	showProgress bool
@@ -155,5 +151,5 @@ func (r *TerminalLine) render() string {
 
 // Update triggers re-rendering
 func (r *TerminalLine) Update() {
-	r.updater.Update()
+	r.terminal.Update()
 }

pkg/discovery/mapping.go

@@ -7,6 +7,7 @@ import (
 	"github.com/grandcat/zeroconf"
 )
 
+// MapToInternalModel takes zeroconf entry and maps it to internal DeviceInfo model
 func MapToInternalModel(entry *zeroconf.ServiceEntry) model.DeviceInfo {
 	version := "unknown"
 

pkg/printers/humanreadable.go

@@ -103,10 +103,7 @@ func (p *HumanReadablePrinter) PrintDevice(info *device.Info, writer io.Writer)
 	if err != nil {
 		log.Fatalf("Invalid pod template: %s", err)
 	}
-	if err := t.Execute(writer, info); err != nil {
-		return err
-	}
-	return nil
+	return t.Execute(writer, info)
 }
 
 // PrintPod writes a pod in human readable detailed format to the writer
@@ -133,10 +130,7 @@ func (p *HumanReadablePrinter) PrintPod(pod *pods.Pod, writer io.Writer) error {
 		"Pod":    pod,
 		"Status": getStatus(pod),
 	}
-	if err := t.Execute(writer, data); err != nil {
-		return err
-	}
-	return nil
+	return t.Execute(writer, data)
 }
 
 // PrintConfig writes list of pods in human readable detailed format to the writer
@@ -147,9 +141,5 @@ func (p *HumanReadablePrinter) PrintConfig(config *config.Config, writer io.Writ
 		log.Fatalf("Invalid config template: %s", err)
 	}
 
-	if err := t.Execute(writer, config); err != nil {
-		return err
-	}
-
-	return nil
+	return t.Execute(writer, config)
 }

pkg/sync/utils.go

@@ -6,6 +6,7 @@ import (
 	"strings"
 )
 
+// MustParseAll parse sync string or fail with Fatal
 func MustParseAll(strings []string) (result []Sync) {
 	for _, str := range strings {
 		sync, err := Parse(str)

pkg/utils/lists.go

@@ -27,7 +27,7 @@ func RotateL(a *[]string) {
 	RotateLBy(a, 1)
 }
 
-// RotateL rotates the string array to left by given steps
+// RotateLBy rotates the string array to left by given steps
 func RotateLBy(a *[]string, i int) {
 	x, b := (*a)[:i], (*a)[i:]
 	*a = append(b, x...)