pythongh-112205: Require @getter and @Setter to be class methods

erlend-aasland · Dec 19, 2023 · 9b4a1f7 · 9b4a1f7
1 parent d71fcde
commit 9b4a1f7
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/Tools/clinic/clinic.py b/Tools/clinic/clinic.py
@@ -5614,6 +5614,10 @@ def state_modulename_name(self, line: str) -> None:
         function_name = fields.pop()
         module, cls = self.clinic._module_and_class(fields)
 
+        if self.kind in {GETTER, SETTER}:
+            if not cls:
+                fail("@getter and @setter must be class level functions")
+
         self.update_function_kind(full_name)
         if self.kind is METHOD_INIT and not return_converter:
             return_converter = init_return_converter()