pythongh-93057: Deprecate positional use of optional sqlite3.connect(…

…) params
erlend-aasland · Aug 14, 2023 · 40996ef · 40996ef
1 parent 6fbaba5
commit 40996ef
Show file tree

Hide file tree

Showing 6 changed files with 71 additions and 5 deletions.
diff --git a/Doc/library/sqlite3.rst b/Doc/library/sqlite3.rst
@@ -355,6 +355,12 @@ Module functions
    .. versionadded:: 3.12
       The *autocommit* parameter.
 
+   .. versionchanged:: 3.13
+      Positional use of the parameters *timeout*, *detect_types*,
+      *isolation_level*, *check_same_thread*, *factory*, *cached_statements*,
+      and *uri* is deprecated.
+      They will become keyword-only parameters in Python 3.15.
+
 .. function:: complete_statement(statement)
 
    Return ``True`` if the string *statement* appears to contain

diff --git a/Doc/whatsnew/3.13.rst b/Doc/whatsnew/3.13.rst
@@ -144,6 +144,15 @@ pathlib
   :meth:`~pathlib.Path.is_dir`.
   (Contributed by Barney Gale in :gh:`77609` and :gh:`105793`.)
 
+sqlite3
+-------
+
+* Passing more than one positional argument to :func:`sqlite3.connect` is
+  deprecated. Parameters *timeout*, *detect_types*, *isolation_level*,
+  *check_same_thread*, *factory*, *cached_statements*, and *uri* is deprecated.
+  They will become keyword-only parameters in Python 3.15.
+  (Contributed by Erlend E. Aasland :gh:`93057`.)
+
 traceback
 ---------
 
@@ -219,6 +228,12 @@ Deprecated
   They will be removed in Python 3.15.
   (Contributed by Victor Stinner in :gh:`105096`.)
 
+* Passing more than one positional argument to :func:`sqlite3.connect` is
+  deprecated. Parameters *timeout*, *detect_types*, *isolation_level*,
+  *check_same_thread*, *factory*, *cached_statements*, and *uri* is deprecated.
+  They will become keyword-only parameters in Python 3.15.
+  (Contributed by Erlend E. Aasland :gh:`93057`.)
+
 Pending Removal in Python 3.14
 ------------------------------
 

diff --git a/Misc/NEWS.d/next/Library/2023-08-14-19-49-02.gh-issue-93057.5nJwO5.rst b/Misc/NEWS.d/next/Library/2023-08-14-19-49-02.gh-issue-93057.5nJwO5.rst
@@ -0,0 +1,5 @@
+Passing more than one positional argument to :func:`sqlite3.connect` is
+deprecated. Parameters *timeout*, *detect_types*, *isolation_level*,
+*check_same_thread*, *factory*, *cached_statements*, and *uri* is
+deprecated. They will become keyword-only parameters in Python 3.15. Patch
+by Erlend E. Aasland.
diff --git a/Modules/_sqlite/clinic/_sqlite3.connect.c.h b/Modules/_sqlite/clinic/_sqlite3.connect.c.h
diff --git a/Modules/_sqlite/clinic/connection.c.h b/Modules/_sqlite/clinic/connection.c.h
diff --git a/Modules/_sqlite/connection.c b/Modules/_sqlite/connection.c
@@ -213,9 +213,10 @@ class sqlite3_int64_converter(CConverter):
 /*[python end generated code: output=da39a3ee5e6b4b0d input=dff8760fb1eba6a1]*/
 
 /*[clinic input]
-_sqlite3.Connection.__init__ as pysqlite_connection_init
+sqlite3.Connection.__init__ as pysqlite_connection_init
 
     database: object
+    * [from 3.15]
     timeout: double = 5.0
     detect_types: int = 0
     isolation_level: IsolationLevel = ""
@@ -234,7 +235,7 @@ pysqlite_connection_init_impl(pysqlite_Connection *self, PyObject *database,
                               int check_same_thread, PyObject *factory,
                               int cache_size, int uri,
                               enum autocommit_mode autocommit)
-/*[clinic end generated code: output=cba057313ea7712f input=9b0ab6c12f674fa3]*/
+/*[clinic end generated code: output=cba057313ea7712f input=219c3dbecbae7d99]*/
 {
     if (PySys_Audit("sqlite3.connect", "O", database) < 0) {
         return -1;