-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test previously failing combos #31
Test previously failing combos #31
Conversation
Yay, all passing. 👍 |
I'm updating the compat. matrix. Edit: done (@ericmj, lemme know if this is still worth keeping: the compat. matrix) |
How did you test if ssl works? |
I didn't, specifically. That said, these combos didn't pass even Edit: pushed some stuff. |
I trimmed down the number of tests, concentrated on non-versioning specific and added a few Ubuntus as per the compatibility matrix. |
- name: Run rebar3 project tests | ||
run: | | ||
cd test-projects/rebar3 | ||
rebar3 as test do xref,dialyzer,ct,cover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make tests go faster.
@ericmj, is there still something you want to check here? Shall we go ahead and merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we are testing too many versions but other than that it looks good.
I'm OK with reducing. Tell me what you'd prefer, either as a general rule or by pointing out the ones you'd want removed, 1 by 1. I'm OK with either direction. 👍 |
Moving to merging this. We can revisit the high number of builds later if deemed required (if they're parallel, time will not be a big issue, I believe). |
No description provided.