Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test previously failing combos #31

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Test previously failing combos #31

merged 1 commit into from
Apr 19, 2021

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Apr 6, 2021

No description provided.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Yay, all passing. 👍

@paulo-ferraz-oliveira
Copy link
Collaborator Author

paulo-ferraz-oliveira commented Apr 6, 2021

I'm updating the compat. matrix.


Edit: done (@ericmj, lemme know if this is still worth keeping: the compat. matrix)

@ericmj
Copy link
Collaborator

ericmj commented Apr 6, 2021

How did you test if ssl works?

@paulo-ferraz-oliveira
Copy link
Collaborator Author

paulo-ferraz-oliveira commented Apr 6, 2021

How did you test if ssl works?

I didn't, specifically. That said, these combos didn't pass even mix -v. Nice catch, though, lemme had that to the rebar3 tests.


Edit: pushed some stuff.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

I trimmed down the number of tests, concentrated on non-versioning specific and added a few Ubuntus as per the compatibility matrix.

- name: Run rebar3 project tests
run: |
cd test-projects/rebar3
rebar3 as test do xref,dialyzer,ct,cover
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make tests go faster.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

@ericmj, is there still something you want to check here? Shall we go ahead and merge?

Copy link
Collaborator

@ericmj ericmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we are testing too many versions but other than that it looks good.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

I still think we are testing too many versions but other than that it looks good.

I'm OK with reducing. Tell me what you'd prefer, either as a general rule or by pointing out the ones you'd want removed, 1 by 1. I'm OK with either direction. 👍

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Moving to merging this. We can revisit the high number of builds later if deemed required (if they're parallel, time will not be a big issue, I believe).

@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit d2707f3 into erlef:main Apr 19, 2021
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the test/previously-failing-combos branch April 19, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants