Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce action description in action.yml (GHA Marketplace constraint) #294

Merged
merged 6 commits into from
Jun 23, 2024

Conversation

starbelly
Copy link
Member

Description

A brief description of your changes.

Github marketplace requires a description be no longer than 125 chars.

Github marketplace requires a description be no longer than 125 chars.
@starbelly
Copy link
Member Author

Note: I also removed OTP 20 and elixir 1.14 from the test matrix. It was failing, but also they are both terribly old now.

@paulo-ferraz-oliveira
Copy link
Collaborator

Note: I also removed OTP 20 and elixir 1.14 from the test matrix. It was failing, but also they are both terribly old now.

If you wanna do this (I don't think there's a maintenance range in place) I'd suggest getting rid of pre-20 info. in the README, too, as well as some of the unit tests (setup-beam.test.js).

@paulo-ferraz-oliveira paulo-ferraz-oliveira self-requested a review June 23, 2024 18:15
@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title Reduce desscription in action.yml Reduce action description in action.yml (GHA Marketplace constraint) Jun 23, 2024
action.yml Outdated
Set up a BEAM-based CI environment, with Erlang/OTP as a base followed, optionally, by other
elements, like Elixir, Gleam, `rebar3` or `hex`, on top of that. Check the [README](https://github.com/erlef/setup-beam)
for updated information.
Set up an Erlang/OTP based CI environment with support for languages and tooling such as Elixir, Gleam, rebar3, and `hex`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd specifically (recently) changed to have "BEAM-based", because you told me searching for BEAM yielded no results in the Marketplace. 😕

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I changed it to this because I was trying to cram all the things in, do you have a better suggestion?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set up a BEAM-based CI environment, supporting languages and tools such as Erlang/OTP, Elixir, Gleam, `rebar3`, and `hex`.

😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'll work!

action.yml Outdated Show resolved Hide resolved
README.md Outdated
@@ -189,7 +189,7 @@ jobs:
name: Erlang/OTP ${{matrix.otp}} / rebar3 ${{matrix.rebar3}}
strategy:
matrix:
otp: ['20.3', '21.3', '22.2']
otp: ['21.3', '21.3', '22.2']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably remove this. It's a repeat.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derpy derp.

README.md Outdated
@@ -165,7 +165,7 @@ jobs:
name: OTP ${{matrix.otp}} / Elixir ${{matrix.elixir}}
strategy:
matrix:
otp: ['20.3', '21.3', '22.2']
otp: ['21.3', '21.3', '22.2']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably remove this. It's a repeat.

@paulo-ferraz-oliveira paulo-ferraz-oliveira self-requested a review June 23, 2024 18:51
@starbelly starbelly merged commit 21a744d into erlef:main Jun 23, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants